Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44642

"Defining Marking Guide" screen in Assignment does not keep session alive

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a new assignment, under grading settings choose Marking Guide and save changes - this should take you to the Advanced grading page
      2. In your config.php, set:

        $CFG->sessiontimeout = 65;
        

      3. Refresh the grading page
      4. Wait at least 90 seconds (in the mean time, you can look to your server logs and verify that there are requests to lib/sessionkeepalive_ajax.php every $CFG->sessiontimeout / 3 seconds aprox).
      5. Enter a name and click save as draft
        • Confirm that you were still logged in

      I'd really recommend reverting the second part of this patch and trying again to confirm that your session timed out.

      Show
      Create a new assignment, under grading settings choose Marking Guide and save changes - this should take you to the Advanced grading page In your config.php, set: $CFG->sessiontimeout = 65; Refresh the grading page Wait at least 90 seconds (in the mean time, you can look to your server logs and verify that there are requests to lib/sessionkeepalive_ajax.php every $CFG->sessiontimeout / 3 seconds aprox). Enter a name and click save as draft Confirm that you were still logged in I'd really recommend reverting the second part of this patch and trying again to confirm that your session timed out.
    • Workaround:
      Hide

      Extend session timeout limit

      Show
      Extend session timeout limit
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-44642-master
    • Sprint:
      FRONTEND Sprint 16
    • Issue size:
      Small

      Description

      This is a complex page that encourages a great deal of editing, adding extra fields and such. It's relatively easy to spend several hours interacting with this page without saving. This (appears to) result in a session timeout and a complete loss of work.

      As far as I naive user is concerned, they are working with Moodle and it's not obvious to them that nothing is being sent to the server. If this is the case, it won't really do. The page should be calling back to the server to update the work on a regular basis.

      This is my interpretation of what's going on based on complaints that we have had from clients about this page timing out on them. I have not examined the code to establish for definite how it works.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/May/15