Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44712

improve Multi-SCO completion handing in activity completion

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Behat tests included for this change.
      Manual instructions for behat test:
      Add the multi-sco package to your course:
      https://github.com/danmarsden/moodle/blob/master_MDL-44712/mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip
      Enable completion tracking at course level
      in the activity completion rules set:
      Show activity as complete when conditions are met
      Tick "completed" checkbox
      make sure require all scos to return completion status is unticked.
      Enter scorm as student - view main page of SCORM - don't navigate through package at all, just hit "exit activity"
      Check to make sure activity completion shows as "complete" for that user.
      Create new package as above, but this time set "Require all scos to return completion status" to yes (ticked)
      Enter scorm as student - view main page - don't navigate through package at all, just hit "exit activity"
      Check to make sure activity completion shows as NOT "complete" for that user.
      Re-enter SCORM and progress through each SCO - (click on each sco name in TOC on left) - you do not need to complete any quizzes - just "view" each sco. - when every sco has been viewed (green tick appears beside the name of the sco in the tree) hit the exit activity link at top right.
      Check to make sure activity completion shows as "complete" for that user.

      Show
      Behat tests included for this change. Manual instructions for behat test: Add the multi-sco package to your course: https://github.com/danmarsden/moodle/blob/master_MDL-44712/mod/scorm/tests/packages/RuntimeMinimumCalls_SCORM12.zip Enable completion tracking at course level in the activity completion rules set: Show activity as complete when conditions are met Tick "completed" checkbox make sure require all scos to return completion status is unticked. Enter scorm as student - view main page of SCORM - don't navigate through package at all, just hit "exit activity" Check to make sure activity completion shows as "complete" for that user. Create new package as above, but this time set "Require all scos to return completion status" to yes (ticked) Enter scorm as student - view main page - don't navigate through package at all, just hit "exit activity" Check to make sure activity completion shows as NOT "complete" for that user. Re-enter SCORM and progress through each SCO - (click on each sco name in TOC on left) - you do not need to complete any quizzes - just "view" each sco. - when every sco has been viewed (green tick appears beside the name of the sco in the tree) hit the exit activity link at top right. Check to make sure activity completion shows as "complete" for that user.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      master_MDL-44712

      Description

      If an user completes a single section of a Multi-SCO, moodle sets the whole activity as completed.

      Example:
      0) create a course and enable the completion
      1) Create a Scorm activity using a Multi-SCO (for example use this one from Rustici examples: Minimum Run-Time Calls http://scorm.com/wp-content/assets/golf_examples/PIFS/RuntimeMinimumCalls_SCORM12.zip )
      2) set the completion settings as follow:

      • Show activity as complete when conditions are met
      • check the option Completed
        3) enrol an user
        4) login as the user and open the scorm activity
        5) complete only a section (geen tick on the left TOC)
        6) exit the activity
        7) the course shows the scorm completed (student happy, theacher not)

      This issues exist since moodle 2.3dev and is still there in 2.7dev

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                6 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/16