Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44749

Collapse plugin should handle suboptimal toolbar configuration

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide
      1. Edit atto settings
        • Set the plugin settings to default
        • Set the collapse toolbar settings to default (5)
      2. In a new tab, find a page with an editor (profile settings/new forum post/etc)
        • Confirm that the collapse plugin is shown
      3. Toggle the button
        • Confirm that the new items were shown
      4. Toggle the button
        • Confirm that the new items were hidden
      5. Reconfigure the toolbar settings to show 11 groups (number of groups - 1)
      6. Refresh the editor
        • Confirm that the collapse plugin is not shown
        • Confirm that all other plugins are shown
      7. Reconfigure the toolbar settings to show 12 groups (exact number of groups)
      8. Refresh the editor
        • Confirm that the collapse plugin is not shown
        • Confirm that all other plugins are shown
      9. Reconfigure the toolbar settings to show 20 groups (more groups than we actually have)
      10. Refresh the editor
        • Confirm that the collapse plugin is not shown
        • Confirm that all other plugins are shown
      11. Reconfigure the toolbar setting to show 1 groups
      12. Refresh the editor
        • Confirm that only the collapse button is shown
        • Confirm that toggling the button toggles visibility of all of the other buttons
      13. Reconfigure the toolbar itself to move the collapse plugin to the end of the list
      14. Refresh the editor
        • Confirm that the button is not shown
        • Confirm that all other buttons are already visible
      Show
      Edit atto settings Set the plugin settings to default Set the collapse toolbar settings to default (5) In a new tab, find a page with an editor (profile settings/new forum post/etc) Confirm that the collapse plugin is shown Toggle the button Confirm that the new items were shown Toggle the button Confirm that the new items were hidden Reconfigure the toolbar settings to show 11 groups (number of groups - 1) Refresh the editor Confirm that the collapse plugin is not shown Confirm that all other plugins are shown Reconfigure the toolbar settings to show 12 groups (exact number of groups) Refresh the editor Confirm that the collapse plugin is not shown Confirm that all other plugins are shown Reconfigure the toolbar settings to show 20 groups (more groups than we actually have) Refresh the editor Confirm that the collapse plugin is not shown Confirm that all other plugins are shown Reconfigure the toolbar setting to show 1 groups Refresh the editor Confirm that only the collapse button is shown Confirm that toggling the button toggles visibility of all of the other buttons Reconfigure the toolbar itself to move the collapse plugin to the end of the list Refresh the editor Confirm that the button is not shown Confirm that all other buttons are already visible
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-44749-master
    • Story Points:
      5
    • Sprint:
      FRONTEND Sprint 11

      Description

      Collapse plugin does not fail gracefully if there are fewer than n groups.
      If there are fewer groups, we should either:

      1. fail gracefully; or
      2. not add the button at all.

      I go for option 2. If the show groups count <= number of groups + 1, then we should not show the plugin IMO.

      I've gone for the groups+1 option because there's a strong chance that the plugin will be in a group of it's own and will thus take up a whole slot.

      It should also not be displayed if it will not be visible by default.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14