Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44758

Atto: Prevent new table creation when within an existing table

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide

      Preparatory work:

      • Create or edit a new post using Atto.
      • Create a table, ideally populating each cell with example content (e.g. 'caption' as the table cell, and then each cell after that being a, b, c etc.).
      • Add some text before and after the table.

      Test:

      1. Position the caret in the caption cell and click the table button.
        • Verify that the table editing menu, rather than the table creation dialog, appears.
        • Verify that the selection has moved to the first cell in the table.
      2. Position the caret in a th cell and click the table button.
        • Verify that the table editing menu, rather than the table creation dialog, appears.
      3. Position the caret in a td cell and click the table button.
        • Verify that the table editing menu, rather than the table creation dialog, appears.
      4. Select three cells in a row and click the table button.
        • Verify that the table editing menu, rather than the table creation dialog, appears.
        • Verify that the menu is targeting the first table cell in your selection.
      5. Select the entire table and click the table button.
        • Verify that the table editing menu, rather than the table creation dialog, appears.
        • Verify that the menu is targeting the first cell in the table.
      6. Select text before the table, ending with a cell in the table that is not the first cell and click the table button.
        • Verify that the table editing menu, rather than the table creation dialog, appears.
        • Verify that the menu is targeting the first cell (in terms of precedence) in your selection.
      7. Select text after the table, ending with a cell in the table that is not the first cell and click the table button.
        • Verify that the table editing menu, rather than the table creation dialog, appears.
        • Verify that the menu is targeting the first cell (in terms of precedence) in your selection.
      8. Place the caret outside the table and click the table button.
        • Verify that the table creation dialog appears.
      Show
      Preparatory work: Create or edit a new post using Atto. Create a table, ideally populating each cell with example content (e.g. 'caption' as the table cell, and then each cell after that being a, b, c etc.). Add some text before and after the table. Test: Position the caret in the caption cell and click the table button. Verify that the table editing menu, rather than the table creation dialog, appears. Verify that the selection has moved to the first cell in the table. Position the caret in a th cell and click the table button. Verify that the table editing menu, rather than the table creation dialog, appears. Position the caret in a td cell and click the table button. Verify that the table editing menu, rather than the table creation dialog, appears. Select three cells in a row and click the table button. Verify that the table editing menu, rather than the table creation dialog, appears. Verify that the menu is targeting the first table cell in your selection. Select the entire table and click the table button. Verify that the table editing menu, rather than the table creation dialog, appears. Verify that the menu is targeting the first cell in the table. Select text before the table, ending with a cell in the table that is not the first cell and click the table button. Verify that the table editing menu, rather than the table creation dialog, appears. Verify that the menu is targeting the first cell (in terms of precedence) in your selection. Select text after the table, ending with a cell in the table that is not the first cell and click the table button. Verify that the table editing menu, rather than the table creation dialog, appears. Verify that the menu is targeting the first cell (in terms of precedence) in your selection. Place the caret outside the table and click the table button. Verify that the table creation dialog appears.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44758-master
    • Story Points:
      20
    • Sprint:
      FRONTEND Sprint 11

      Description

      For now, you can create a table in another table by:

      1. Clicking the table icon when the cursor is in the caption
      2. Selecting more than one cell
      3. Click the table icon

      This also happens when you select the caption cell (at step 2).

      Expected result: The table editing context menu will pop-up

      Actual result: The new table creation dialogue appears and when you click to add a new table it doesn't work.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14