Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44770

Change table context menu, to open from the table button, not the table cell

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide
      1. Create or edit a post using Atto.
      2. Create a new table by clicking the table button.
      3. Move your caret to one of the table cells.
      4. Click the table button.
      5. Verify that the table context menu now opens from the table button.
      Show
      Create or edit a post using Atto. Create a new table by clicking the table button. Move your caret to one of the table cells. Click the table button. Verify that the table context menu now opens from the table button.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44770-master
    • Sprint:
      FRONTEND Sprint 11
    • Story Points (Obsolete):
      8
    • Sprint:
      FRONTEND Sprint 11

      Description

      Also maybe change the wording to e.g. "Insert column after current cell".

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            cibot CiBoT added a comment -

            Results for MDL-44770

            • Remote repository: git://github.com/jethac/moodle.git
            Show
            cibot CiBoT added a comment - Results for MDL-44770 Remote repository: git://github.com/jethac/moodle.git Remote branch MDL-44770 -master to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2626 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2626/artifact/work/smurf.html
            Hide
            cibot CiBoT added a comment -

            Results for MDL-44770

            • Remote repository: git://github.com/jethac/moodle.git
            Show
            cibot CiBoT added a comment - Results for MDL-44770 Remote repository: git://github.com/jethac/moodle.git Remote branch MDL-44770 -master to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2627 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2627/artifact/work/smurf.html
            Hide
            damyon Damyon Wiese added a comment -

            Noting that there is already a separate issue to make the styles of the drop down menus in Atto consistent.

            Also there is a separate issue to fix the issue with selecting multiple cells / captions.

            So - this issue, fixing only what is described here seems correct.

            Sending for integration - thanks Jetha.

            Show
            damyon Damyon Wiese added a comment - Noting that there is already a separate issue to make the styles of the drop down menus in Atto consistent. Also there is a separate issue to fix the issue with selecting multiple cells / captions. So - this issue, fixing only what is described here seems correct. Sending for integration - thanks Jetha.
            Hide
            cibot CiBoT added a comment -

            Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

            Show
            cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
            Hide
            marina Marina Glancy added a comment -

            Jetha, can you rebase over integration please? There are conflicts and my shifter refuses to work

            Show
            marina Marina Glancy added a comment - Jetha, can you rebase over integration please? There are conflicts and my shifter refuses to work
            Hide
            jethac Jetha Chan added a comment -

            Sure thing.

            Show
            jethac Jetha Chan added a comment - Sure thing.
            Hide
            marina Marina Glancy added a comment -

            Thanks Jetha, integrated in master

            Show
            marina Marina Glancy added a comment - Thanks Jetha, integrated in master
            Hide
            phalacee Jason Fowler added a comment -

            All good Jetha

            Show
            phalacee Jason Fowler added a comment - All good Jetha
            Hide
            marina Marina Glancy added a comment -

            Thanks for your hard work. Your code is now part of Moodle.

            Show
            marina Marina Glancy added a comment - Thanks for your hard work. Your code is now part of Moodle.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14