Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44798

Atto: Does not work in IE <= 8

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.7
    • 2.7
    • HTML Editor (Atto)
    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-44798-master
    • Hide

      Please test in as many browsers as possible to check for regressions. This must be tested in IE8 and IE7 too.

      1. Open a page with at least two editors
      2. Click on a button before you focus on the editor
        • Confirm the pleasant absence of JS errors
      3. Click into an editor
        • Confirm the pleasant absence of JS errors
      4. Type some text, select it, and press the Bold button
        • Confirm the pleasant absence of JS errors
      Show
      Please test in as many browsers as possible to check for regressions. This must be tested in IE8 and IE7 too. Open a page with at least two editors Click on a button before you focus on the editor Confirm the pleasant absence of JS errors Click into an editor Confirm the pleasant absence of JS errors Type some text, select it, and press the Bold button Confirm the pleasant absence of JS errors

    Description

      It seems there is some JS error that is preventing the kitchen sink button from working in IE8. However, IE9 and IE11 seem to be fine.

      Error message when kitchen sink icon is pressed:

      Line: 3976
      Error: Invalid argument.
      

      This relates to the following code. 3976 is the line starting containerElement.insertBefore(...

              // Move the working range through the container's children, starting at the end and working backwards, until the
              // working range reaches or goes past the boundary we're interested in
              do {
                  containerElement.insertBefore(workingNode, workingNode.previousSibling);
                  workingRange.moveToElementText(workingNode);
              } while ( (comparison = workingRange.compareEndPoints(workingComparisonType, textRange)) > 0 &&
                      workingNode.previousSibling);
      ...
      

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              salvetore Michael de Raadt
              Frédéric Massart Frédéric Massart
              Dan Poltawski Dan Poltawski
              Rajesh Taneja Rajesh Taneja
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/May/14