[MDL-44825] mnet communication debugging should dump more info when mnet debugging is turned on. - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

setup mnet.
turn on mnet debugging
watch logs
do an mnet auth

test that the keys communicated are logged.
Show
setup mnet. turn on mnet debugging watch logs do an mnet auth test that the keys communicated are logged.
Affected Branches:
MOODLE_26_STABLE
Pull from Repository:
https://github.com/nebgor/moodle.git
Pull Master Diff URL:
https://github.com/nebgor/moodle/commit/388cab3ed7418a2768a8b1043209be55cb2c1510

easy fix:

with $CFG->mnet_rpcdebug = true;

mnet/xmlrpc/client.php's mnet_xmlrpc_client::send() should dump raw comms into err log like so:

        $timestamp_send    = time();

        mnet_debug("about to send the curl request");

        $this->rawresponse = curl_exec($httprequest);

        mnet_debug("managed to complete a curl request");

        $timestamp_receive = time();

+        mnet_debug('raw response: '.$this->rawresponse);