Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44837

Behat: 'dialogue' selector only works for confirm dialogues

    XMLWordPrintable

    Details

      Description

      The "dialogue" selector in Behat is currently only used in one place (the quiz test). Perhaps unsurprisingly, it doesn't work properly if anyone tries to use it anywhere else - the xpath statement only matches confirm dialogues, because it relies on an <h1> element which is not included in default Moodle notification dialogues.

      Also the way it's written is kind of horrible even by xpath standards (basically, previously it was like "element a/required child b/parent a" so it has element a twice; it should be "element a[required child b]"). And it's written all on one line so as to make it hard to read.

      I'll submit a fix for this.

        Attachments

          Activity

            People

            • Assignee:
              quen Sam Marshall
              Reporter:
              quen Sam Marshall
              Peer reviewer:
              Tim Hunt
              Integrator:
              Marina Glancy
              Tester:
              Andrew Nicols
              Participants:
              Component watchers:
              Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14