Moodle
  1. Moodle
  2. MDL-4485

Assignment (online and uploadsingle) views are not logged

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.8.6, 1.9.1
    • Component/s: Assignment (2.2)
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_16_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      27528

      Description

      The assignment_base class has in it's view() method:

      add_to_log($this->course->id, assignment, view, view.php?id={$this->cm->id},

      $this->assignment->id, $this->cm->id);

      but since this (super) method is not called from assignment_uploadsingle::view() and assignment_online::view(), these assignment views are not logged.

      Suggestion: add the above mentioned line to these subclass methods. Check for other similar places too.

        Activity

        Hide
        Martin Dougiamas added a comment -

        Just fixed online as uploadsingle had been fixed already.

        Show
        Martin Dougiamas added a comment - Just fixed online as uploadsingle had been fixed already.
        Hide
        Mathieu Petit-Clair added a comment -

        Tested & closed.

        Show
        Mathieu Petit-Clair added a comment - Tested & closed.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: