Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44850

'eot' font type not served in font.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.2, 2.7
    • Fix Version/s: 2.6.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Using the supplied font 'https://tracker.moodle.org/secure/attachment/37258/BonvenoCF-Light-webfont.eot' which is GPLv2 licensed from: http://www.fontsquirrel.com/fonts/BonvenoCF.
      2. Place the eot file in a new folder 'fonts' in the 'Clean' theme.
      3. Edit the 'styles/custom.css' file and add:

      @font-face {
      		 
        font-family: 'BonvenoCF';
      		 
        src: url('[[font:theme|BonvenoCF-Light-webfont.eot]]') format('embedded-opentype');
      		 
      }
      		 
       
      		 
      body {
      		 
        font-family: 'BonvenoCF';
      		 
      }

      4. With a compatible EOT font rendering browser and version (IE) as listed on: http://caniuse.com/#feat=eot.
      5. Purge all caches.
      6. Confirm that the body font for the front page (or any page) looks like the sample as shown on: http://www.fontsquirrel.com/fonts/BonvenoCF.

      Show
      1. Using the supplied font 'https://tracker.moodle.org/secure/attachment/37258/BonvenoCF-Light-webfont.eot' which is GPLv2 licensed from: http://www.fontsquirrel.com/fonts/BonvenoCF . 2. Place the eot file in a new folder 'fonts' in the 'Clean' theme. 3. Edit the 'styles/custom.css' file and add: @font-face { font-family: 'BonvenoCF'; src: url('[[font:theme|BonvenoCF-Light-webfont.eot]]') format('embedded-opentype'); }   body { font-family: 'BonvenoCF'; } 4. With a compatible EOT font rendering browser and version (IE) as listed on: http://caniuse.com/#feat=eot . 5. Purge all caches. 6. Confirm that the body font for the front page (or any page) looks like the sample as shown on: http://www.fontsquirrel.com/fonts/BonvenoCF .
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-44850_master
    • Pull Master Diff URL:

      Description

      In '/theme/font.php' there is the following code:

      } else if (preg_match('/^[a-z0-9_-]+\.oet$/i', $font, $matches)) {
      		 
          // IE8 must die!!!
      		 
          $font = $matches[0];
      		 
          $mimetype = 'application/vnd.ms-fontobject';
      		 
       
      		 
      } else {
      		 
          font_not_found();
      		 
      }

      Which can be found here: https://github.com/moodle/moodle/blob/MOODLE_26_STABLE/theme/font.php#L73.

      This appears to be a typo as there is no 'oet' font type. It should be 'eot' and therefore 'eot' font types are never served.

        Attachments

          Activity

            People

            Assignee:
            gb2048 Gareth J Barnard
            Reporter:
            gb2048 Gareth J Barnard
            Peer reviewer:
            Mary Evans
            Integrator:
            Marina Glancy
            Tester:
            Andrew Davis
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            3 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/May/14