Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44868

Atto: Toolbar can set focus on disabled elements

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide
      1. Open Atto
      2. Switch to the HTML view using the keyboard
      3. Press left/right several time to try to get focus on another button
      4. Tab in the editor, and shift tab in the toolbar
      5. Confirm that the focus is set on the HTML button
      6. Repeat using the mouse to switch to HTML and back
      1. Enter some text to enable the undo button
      2. Use the keyboard to get to the undo button
      3. Undo everything you can to get a disabled undo button
      4. Make sure when the button is disabled the focus is set on the previous button
      5. Repeat with the "Redo" button
      6. Repeat with the mouse

      Regression test

      1. Use the keyboard to navigate through the toolbar, but do press enter on any button
      2. Tab to the editor, shift tab to the toolbar
      3. Make sure the button that is focussed is the last one you had focussed
      4. Switch to HTML view and back
      5. Navigate in the toolbar using the keyboard
      6. Tab in the editor and back
      7. Make sure one tab press is enough to get in the editor (Previously the tab was set on the HTML button)
      8. Make sure when you tab back to the toolbar the focus in on the last button you focussed
      Show
      Open Atto Switch to the HTML view using the keyboard Press left/right several time to try to get focus on another button Tab in the editor, and shift tab in the toolbar Confirm that the focus is set on the HTML button Repeat using the mouse to switch to HTML and back Enter some text to enable the undo button Use the keyboard to get to the undo button Undo everything you can to get a disabled undo button Make sure when the button is disabled the focus is set on the previous button Repeat with the "Redo" button Repeat with the mouse Regression test Use the keyboard to navigate through the toolbar, but do press enter on any button Tab to the editor, shift tab to the toolbar Make sure the button that is focussed is the last one you had focussed Switch to HTML view and back Navigate in the toolbar using the keyboard Tab in the editor and back Make sure one tab press is enough to get in the editor (Previously the tab was set on the HTML button) Make sure when you tab back to the toolbar the focus in on the last button you focussed
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44868-master
    • Sprint:
      FRONTEND Sprint 11

      Description

      This issue has 2 sides

      1. If you switch to HTML view, then tab to the toolbar and hit left/right, you cannot get leave the toolbar and re-acquire focus.
      2. A button that gets disabled (undo, etc...) keeps the tabIndex and prevents the toolbar from re-acquiring focus.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Dan Poltawski
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14