Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44928

More incorrect urls and strings in many events

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: Events API
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a forum
      2. Edit settings, then select "A single, simple discussion"
      3. Make a post, edit the post. Reply, delete the reply.
      4. Click "Show/edit current subscribers" under "Forum administration" in Navigation
      5. Add a subscriber, then remove a subscriber
      6. Go to My profile settings>Edit Profile. Set "Forum tracking" to "Yes"
      7. Select "Track unread posts" then "Don't track unread posts"
      8. Check that the links in the "event name" column have correct urls (using "f=") for the following events:
        • Post created
        • Post updated
        • Post deleted
        • Subscription created
        • Subscription deleted
        • Read tracking enabled
        • Read tracking disabled
      9. Run unit tests: "vendor/bin/phpunit mod/forum/tests/events_test.php"
      Show
      Create a forum Edit settings, then select "A single, simple discussion" Make a post, edit the post. Reply, delete the reply. Click "Show/edit current subscribers" under "Forum administration" in Navigation Add a subscriber, then remove a subscriber Go to My profile settings>Edit Profile. Set "Forum tracking" to "Yes" Select "Track unread posts" then "Don't track unread posts" Check that the links in the "event name" column have correct urls (using "f=") for the following events: Post created Post updated Post deleted Subscription created Subscription deleted Read tracking enabled Read tracking disabled Run unit tests: "vendor/bin/phpunit mod/forum/tests/events_test.php"
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44928-master

      Description

      Many events still have incorrect urls. This event has been created to represent these outstanding issues.

      Identified so far:

      • mod_forum\event\subscription_created and mod_forum\event\subscription_deleted have erroneous URLs of form "mod/forum/view.php?id=1" instead of "mod/forum/view.php?f=1". It's not that the calling convention is incorrect - you can use id instead of f - it's more that the value is wrong, e.g. on my test site, view.php?f=1 is equivalent to view.php?id=207. The URLs need to either take the form f=X or have X be the appropriate number.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              johno John Okely
              Reporter:
              jethac Jetha Chan
              Peer reviewer:
              Petr Skoda
              Integrator:
              Sam Hemelryk
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14