Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44938

Upgrade warning for scorm activities with scormtype "imsrepository"

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6, 2.7
    • Fix Version/s: 2.6.3
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      set up a 2.5 site with some SCORM packages.
      modify a record in the mdl_scorm table by changing the scormtype field for 1 or more existing SCORM activities to "imsrepository" then upgrade the site to 2.6. during upgrade make sure that the notice below doesn't appear:
      Notice: Use of undefined constant SCORM_TYPE_EXTERNAL - assumed 'SCORM_TYPE_EXTERNAL'

      NOTE: Unlikely that the SCORM will work correctly in the site after upgrade as it wasn't an imsrepository type in the first place.

      Show
      set up a 2.5 site with some SCORM packages. modify a record in the mdl_scorm table by changing the scormtype field for 1 or more existing SCORM activities to "imsrepository" then upgrade the site to 2.6. during upgrade make sure that the notice below doesn't appear: Notice: Use of undefined constant SCORM_TYPE_EXTERNAL - assumed 'SCORM_TYPE_EXTERNAL' NOTE: Unlikely that the SCORM will work correctly in the site after upgrade as it wasn't an imsrepository type in the first place.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      master_MDL-44938

      Description

      When upgrading from pre 2.5 a warning is thrown for any SCORM activities that have the value "imsrepository" in the scormtype column.

      The upgrade is trying to reference the SCORM_TYPE_EXTERNAL (line 88 on current 2.6 STABLE) constant but the lib file that includes the definition of the constant hasn't been included.

      This issue is hard to reproduce as it relies on the very old $CFG->repositoryactivate setting to be turned on although this can occur when upgrading old sites.

      You can force the error to show by changing the scormtype field for 1 or more existing SCORM activities to "imsrepository" then upgrade the site to 2.6. You will get the message

      Notice: Use of undefined constant SCORM_TYPE_EXTERNAL - assumed 'SCORM_TYPE_EXTERNAL'

        Attachments

          Activity

            People

            Assignee:
            danmarsden Dan Marsden
            Reporter:
            aly Alastair Munro
            Peer reviewer:
            Petr Skoda
            Integrator:
            Marina Glancy
            Tester:
            Rajesh Taneja
            Participants:
            Component watchers:
            Damyon Wiese, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/May/14