Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44950

All settings should be positive in logstore_external

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: Logging
    • Labels:
    • Testing Instructions:
      Hide

      Setup

      1. Create a table exactly like mdl_logstore_standard_log in a database other than your moodle database.

      Test

      1. Apply upgrade and make sure you get notification about new settings in logstore_database
      2. Run unit tests in admin/tool/log/store/database/tests/store_test.php and make sure they pass
      3. Set up(using settings tab) and enable External log store (My home ► Site administration ► Plugins ► Logging ► Manage log stores)
      4. Create a module, check your database table that you are using for the external logstore and make sure there is an entry for the same.
      5. Now change the setting for external logstore and uncheck "Create" action and "Teaching" level
      6. Create another module
      7. Check database table again and make sure there are no entries added for "course module created" action
      Show
      Setup Create a table exactly like mdl_logstore_standard_log in a database other than your moodle database. Test Apply upgrade and make sure you get notification about new settings in logstore_database Run unit tests in admin/tool/log/store/database/tests/store_test.php and make sure they pass Set up(using settings tab) and enable External log store (My home ► Site administration ► Plugins ► Logging ► Manage log stores) Create a module, check your database table that you are using for the external logstore and make sure there is an entry for the same. Now change the setting for external logstore and uncheck "Create" action and "Teaching" level Create another module Check database table again and make sure there are no entries added for "course module created" action
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-44950-master

      Description

      As seen in the screen shot, the first filter is a positive one, where as the rest are negative.

      All filters should be positive for usability.

      I don't think this requires any upgrade code as the code was committed to only master.

        Attachments

          Activity

            People

            Assignee:
            ankit_frenz Ankit Agarwal
            Reporter:
            ankit_frenz Ankit Agarwal
            Peer reviewer:
            Petr Skoda
            Integrator:
            Marina Glancy
            Tester:
            Frédéric Massart
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/May/14