Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44951

Forum post CSS tweaks

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.5.6, 2.6.3
    • Component/s: Forum, Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Before applying the patch:
        • Use Site Administration -> Development -> Make test course to make a test course.
        • Go to the forum of the test course and open a thread with multiple replies.
          • Observe that alignments are kind of wacky - in particular, forum post bodies are half-indented under avatars.
        • Use Course Administration -> Users -> Groups to set up some groups for the users in the thread you opened, each with an icon (e.g. Gryffindor, Slytherin, Prefects, etc.)
          • Give one user one group, the second user two groups, the third user three groups.
        • Go back to the thread you opened and refresh the page; observe that the users now have stacked group icons below their avatars.
          • Observe that the vertical position of the post controls on the post of the user with multiple groups is higher than it should be (it should be at the bottom of the post, but is higher because the stacked group icons are taller than the user's post).
        • Reply to the thread as a user without a group.
          • Observe that the body of your post has indentation inconsistent with that of users with groups.
        • Go to Site administration -> Language -> Language packs and install a right-to-left language, like Hebrew.
        • Go back to the thread you opened and switch language to Hebrew.
          • Observe that right-to-left display is just as ugly.
      2. Apply the patch.
        • Observe that each identified pre-patch issue has been resolved.
      Show
      Before applying the patch: Use Site Administration -> Development -> Make test course to make a test course. Go to the forum of the test course and open a thread with multiple replies. Observe that alignments are kind of wacky - in particular, forum post bodies are half-indented under avatars. Use Course Administration -> Users -> Groups to set up some groups for the users in the thread you opened, each with an icon (e.g. Gryffindor, Slytherin, Prefects, etc.) Give one user one group, the second user two groups, the third user three groups. Go back to the thread you opened and refresh the page; observe that the users now have stacked group icons below their avatars. Observe that the vertical position of the post controls on the post of the user with multiple groups is higher than it should be (it should be at the bottom of the post, but is higher because the stacked group icons are taller than the user's post). Reply to the thread as a user without a group. Observe that the body of your post has indentation inconsistent with that of users with groups. Go to Site administration -> Language -> Language packs and install a right-to-left language, like Hebrew. Go back to the thread you opened and switch language to Hebrew. Observe that right-to-left display is just as ugly. Apply the patch. Observe that each identified pre-patch issue has been resolved.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44951-master

      Description

      I find myself adding this to every Clean theme to make forum posts look OK:

      .posting.fullpost {
         margin-top:10px;
      }
       
      img.userpicture {
         margin-right: 10px !important;
      }
      

      Can we fix this upstream please?

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14