Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44967

Upgrade fails if the site has already removed all core thems

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: Installation, Themes
    • Labels:

      Description

      To replicate and test:

      1. Checkout Moodle 2.6 code base.
      2. Remove all core themes except base, bootstrapbase, and clean.
      3. Perform a clean install using this code base.
      4. Checkout the Moodle 2.7 code base
      5. Run upgrade via cli (php admin/cli/upgrade.php --non-interactive --allow-unstable)
      6. Check the upgrade completes successfully.

      At present the following is encountered:

      Default exception handler: Coding error detected, it must be fixed by a programmer: moodle_database::get_in_or_equal() does not accept empty arrays Debug:
      Error code: codingerror

      • line 693 of /lib/dml/moodle_database.php: coding_exception thrown
      • line 3199 of /lib/db/upgrade.php: call to moodle_database->get_in_or_equal()
      • line 1560 of /lib/upgradelib.php: call to xmldb_main_upgrade()
      • line 165 of /admin/cli/upgrade.php: call to upgrade_core()

      !!! Coding error detected, it must be fixed by a programmer: moodle_database::get_in_or_equal() does not accept empty arrays !!!
      !!
      Error code: codingerror !!
      !! Stack trace: * line 693 of /lib/dml/moodle_database.php: coding_exception thrown

      • line 3199 of /lib/db/upgrade.php: call to moodle_database->get_in_or_equal()
      • line 1560 of /lib/upgradelib.php: call to xmldb_main_upgrade()
      • line 165 of /admin/cli/upgrade.php: call to upgrade_core()

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              samhemelryk Sam Hemelryk
              Peer reviewer:
              Petr Skoda Petr Skoda
              Integrator:
              Damyon Wiese Damyon Wiese
              Tester:
              Adrian Greeve Adrian Greeve
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14