Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44972

New dialogs don't get auto focus for "Link", "Image", "Media", "Table" etc

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide

      Open these Atto dialogues and verify that the focus is set to the first input in the forms:

      1. Table
      2. Image
      3. Media
      4. Link
      5. Equation

      Open some other dialogues in Moodle and just check that they work and the default focus behaviour hasn't changed.

      1. Activity chooser (default focus should be on Assignment input field)
      2. Help popup (default focus should be on close button)
      3. File picker (default focus should be on the "fp-content" div

      I tried to write some better test for regressions - but the behaviour from before the patch was a bit random too.

      Show
      Open these Atto dialogues and verify that the focus is set to the first input in the forms: Table Image Media Link Equation Open some other dialogues in Moodle and just check that they work and the default focus behaviour hasn't changed. Activity chooser (default focus should be on Assignment input field) Help popup (default focus should be on close button) File picker (default focus should be on the "fp-content" div I tried to write some better test for regressions - but the behaviour from before the patch was a bit random too.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44972-master

      Description

      I noticed this when adding a link ...

      1. Select some text
      2. Hit the "Link" button to make it a link
      3. Type a URL or hit Paste
      4. Nothing happens because the URL field was not selected.

      In fact, one time the text I typed went in to the main text editor behind the dialog!

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              dougiamas Martin Dougiamas
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Marina Glancy
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14