Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44974

Admin renderer initialisation occurs prematurely

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.2
    • Fix Version/s: 2.6.4, 2.7.1
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide
      1. Run and upgrade (just bump version.php if you need to) and check during upgrade that admin/index.php has the maintenance layout.
      2. Visit the admin notifications page and check that everything renders correctly and that you get an admin layout.
      3. Wait for ci to pass the entire behat suite
      Show
      Run and upgrade (just bump version.php if you need to) and check during upgrade that admin/index.php has the maintenance layout. Visit the admin notifications page and check that everything renders correctly and that you get an admin layout. Wait for ci to pass the entire behat suite
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      44974-28
    • Pull Master Diff URL:

      Description

      If you look at admin/index.php round about line 382 you will find a call as follows:

      $output = $PAGE->get_renderer('core', 'admin');
      

      This call initialises the renderer and triggers the initialisation of theme, page and output.
      You'll notice you look a couple of lines down that after this we continue to set up page.
      Also if you follow through the logic in that code block you'll find that $output isn't already used.
      This has lead to at least one issue in the past (fixed in another way) and really needs to be dealt with.

        Attachments

          Activity

            People

            Assignee:
            samhemelryk Sam Hemelryk
            Reporter:
            samhemelryk Sam Hemelryk
            Peer reviewer:
            Frédéric Massart Frédéric Massart
            Integrator:
            Damyon Wiese Damyon Wiese
            Tester:
            Mark Nelson Mark Nelson
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jul/14