Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45008

Atto: Unlink button only works with selected text, not while the caret is in a link

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide

      Note: This issue does not change the different behaviour of IE. I think that doing so is beyond the scope of this issue as it involves writing a polyfill for the browser behaviour for a single browser. As a result, IE will have the following differences:

      • when unlinking a part of a link, the whole link will be unselected;
      • only the word that was selected within the link will be selected after that whole link is unselected.

      Test in all supported browsers:

      1. Open a page with the atto editor
      2. Turn on HTML mode and copy/paste in the following content

        <a href="http://www.google.com">This is a link with some long content</a>&nbsp;This is content without a link&nbsp;<a href="http://www.google.com">This is a link with some long content</a><br></p>
        

      3. turn off HTML mode, and select the content of the editor and copy it to your paste buffer (pro tip)
      4. place the cursor inside the first link (without a proper selection)
      5. click the unlink button
        • Confirm that the whole link was unlinked
        • Confirm that the whole link was selected
      6. Select all and replace the content with your paste buffer
      7. place the cursor inside the second link (without a proper selection)
      8. click the unlink button
        • Confirm that the whole link was unlinked
        • Confirm that the whole link was selected
      9. Select all and replace the content with your paste buffer
      10. Select part of the first link
      11. click the unlink button
        • Confirm that the selection was unlinked
        • Confirm that the selection was still selected
      12. Select all and replace the content with your paste buffer
      13. Select part of the second link
      14. click the unlink button
        • Confirm that the selection was unlinked
        • Confirm that the selection was still selected
      15. Select all and replace the content with your paste buffer
      16. Select all of of the first link
      17. Click the unlink button
        • Confirm that the selection was unlinked
        • Confirm that the selection was still selected
      18. Select all and replace the content with your paste buffer
      19. Select all of of the second link
      20. Click the unlink button
        • Confirm that the selection was unlinked
        • Confirm that the selection was still selected
      21. Select all and replace the content with your paste buffer
      22. Select a range which encompasses both links but not all of them
      23. Click the unlink button
        • Confirm that only the selection was unlinked
        • Confirm that the selection was still selected
      24. Rejoice, for unlinking works
      Show
      Note : This issue does not change the different behaviour of IE. I think that doing so is beyond the scope of this issue as it involves writing a polyfill for the browser behaviour for a single browser. As a result, IE will have the following differences: when unlinking a part of a link, the whole link will be unselected; only the word that was selected within the link will be selected after that whole link is unselected. Test in all supported browsers: Open a page with the atto editor Turn on HTML mode and copy/paste in the following content <a href="http://www.google.com">This is a link with some long content</a>&nbsp;This is content without a link&nbsp;<a href="http://www.google.com">This is a link with some long content</a><br></p> turn off HTML mode, and select the content of the editor and copy it to your paste buffer (pro tip) place the cursor inside the first link (without a proper selection) click the unlink button Confirm that the whole link was unlinked Confirm that the whole link was selected Select all and replace the content with your paste buffer place the cursor inside the second link (without a proper selection) click the unlink button Confirm that the whole link was unlinked Confirm that the whole link was selected Select all and replace the content with your paste buffer Select part of the first link click the unlink button Confirm that the selection was unlinked Confirm that the selection was still selected Select all and replace the content with your paste buffer Select part of the second link click the unlink button Confirm that the selection was unlinked Confirm that the selection was still selected Select all and replace the content with your paste buffer Select all of of the first link Click the unlink button Confirm that the selection was unlinked Confirm that the selection was still selected Select all and replace the content with your paste buffer Select all of of the second link Click the unlink button Confirm that the selection was unlinked Confirm that the selection was still selected Select all and replace the content with your paste buffer Select a range which encompasses both links but not all of them Click the unlink button Confirm that only the selection was unlinked Confirm that the selection was still selected Rejoice, for unlinking works
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-45008-master

      Description

      Create a link in Atto, then click inside the linked text. Click the remove link button, and the link will remain. Select the entire link and click the remove link button and the link will be removed.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              phalacee Jason Fowler
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Marina Glancy
              Tester:
              Dan Poltawski
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14