Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45045

Fake blocks show DND empty region when editing and clicked on.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.5, 2.6.2, 2.7
    • Fix Version/s: 2.5.6, 2.6.3
    • Component/s: Blocks, Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select the Clean theme.
      2. If docking is available and enabled in Clean's 'config.php' file, then set to 'false' to disable it.
      3. Create a course and add a Book with two chapters, a Lesson with two contents pages and a Quiz with two questions.
      4. Navigate to the Book and turn on editing under 'Course administration' of the 'Administration' block.
      5. Observe that clicking on a chapter link on the 'Table of contents' fake block first causes the content area to shrink and an empty area appear on the right (LTR language) for the 'side-post' DND area.
      6. Navigate to the Lesson and observe that clicking on the content page links on the 'Lesson menu' fake block first causes the content area to shrink and an empty area appear on the right (LTR language) for the 'side-post' DND area.
      7. Navigate to the Quiz, preview, and observe that clicking on the question number links on the 'Quiz navigation' fake block first causes the content area to shrink and an empty area appear on the right (LTR language) for the 'side-post' DND area.
      8. Apply the patch.
      9. Repeat clicking of links on the 'Table of contents' for the Book, 'Lesson menu' for the Lesson and 'Quiz navigation' for Quiz does not cause the side-post drop area to appear.
      Show
      Select the Clean theme. If docking is available and enabled in Clean's 'config.php' file, then set to 'false' to disable it. Create a course and add a Book with two chapters, a Lesson with two contents pages and a Quiz with two questions. Navigate to the Book and turn on editing under 'Course administration' of the 'Administration' block. Observe that clicking on a chapter link on the 'Table of contents' fake block first causes the content area to shrink and an empty area appear on the right (LTR language) for the 'side-post' DND area. Navigate to the Lesson and observe that clicking on the content page links on the 'Lesson menu' fake block first causes the content area to shrink and an empty area appear on the right (LTR language) for the 'side-post' DND area. Navigate to the Quiz, preview, and observe that clicking on the question number links on the 'Quiz navigation' fake block first causes the content area to shrink and an empty area appear on the right (LTR language) for the 'side-post' DND area. Apply the patch. Repeat clicking of links on the 'Table of contents' for the Book, 'Lesson menu' for the Lesson and 'Quiz navigation' for Quiz does not cause the side-post drop area to appear.
    • Workaround:
      Hide

      Change the 'incourse' layout in the theme's config.php to be 'side-pre' only.

      Show
      Change the 'incourse' layout in the theme's config.php to be 'side-pre' only.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-45045_master

      Description

      Initially reported in my contributed theme 'Shoehorn' in the theme forum post: https://moodle.org/mod/forum/discuss.php?d=257579#p1119021 - it appears that when editing is on and you are using a fake block and click on it then the block JS causes the empty side-post area to show as a drop target (given that side-post is initially empty).

      This is odd as the fake block cannot be moved and attempting to click on a navigation link (in either the book or lesson modules) does not result in a clear navigation action but rather the content size changing.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                gb2048 Gareth J Barnard
                Reporter:
                gb2048 Gareth J Barnard
                Peer reviewer:
                Mary Evans
                Integrator:
                Sam Hemelryk
                Tester:
                Adrian Greeve
                Participants:
                Component watchers:
                Adrian Greeve, Mihail Geshoski, Peter Dias, Bas Brands, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14