Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45048

repository_wikimedia calls optional_param in constructor leading to warnings if param name clash

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.5, 2.6.2
    • Fix Version/s: 2.5.6, 2.6.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Regression test

      1. Go to your privates files
      2. Pick a file from Wikimedia
        • Make sure the results are loaded as you scroll
        • Make sure you can do another search by clicking Wikimedia in the list of repositories
      3. Disable Javascript and reload the page
      4. Pick a file from Wikimedia
        • Make sure you can go to the next page in the results (there is a bug about the first page being the second, raise an issue if you like lol)
        • Make sure you can do a different search by going back

      Test

      1. Enable activity completion and availability
      2. Create a course and add a page activity
      3. Add a grade restriction and set min grade to "X"
      4. Save
      5. Make sure you do not see any warnings
      Show
      Regression test Go to your privates files Pick a file from Wikimedia Make sure the results are loaded as you scroll Make sure you can do another search by clicking Wikimedia in the list of repositories Disable Javascript and reload the page Pick a file from Wikimedia Make sure you can go to the next page in the results (there is a bug about the first page being the second, raise an issue if you like lol) Make sure you can do a different search by going back Test Enable activity completion and availability Create a course and add a page activity Add a grade restriction and set min grade to "X" Save Make sure you do not see any warnings
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45048-master

      Description

      Steps to reproduce:

      1. enablecompletion and enableavailability
      2. Create a course and add page activity
      3. Add grade restriction and set min grade "XYZ"
      4. Save and you will see following warning

        Invalid array parameter detected in required_param(): page
        line 637 of /lib/moodlelib.php: call to debugging()
        line 48 of /repository/wikimedia/lib.php: call to optional_param()
        line 2929 of /repository/lib.php: call to repository_wikimedia->__construct()
        line 81 of /cache/lib.php: call to repository::wake_from_cache()
        line 223 of /cache/lib.php: call to cache_cached_object->restore_object()
        line 81 of /cache/lib.php: call to cacheable_object_array::wake_from_cache()
        line 310 of /cache/classes/loaders.php: call to cache_cached_object->restore_object()
        line 1074 of /repository/lib.php: call to cache->get()
        line 3263 of /repository/lib.php: call to repository::get_instances()
        line 342 of /lib/form/editor.php: call to initialise_filepicker()
        line 183 of /lib/pear/HTML/QuickForm/Renderer/Tableless.php: call to MoodleQuickForm_editor->toHtml()
        line 2773 of /lib/formslib.php: call to HTML_QuickForm_Renderer_Tableless->renderElement()
        line 403 of /lib/pear/HTML/QuickForm/element.php: call to MoodleQuickForm_Renderer->renderElement()
        line 1632 of /lib/pear/HTML/QuickForm.php: call to HTML_QuickForm_element->accept()
        line 1694 of /lib/formslib.php: call to HTML_QuickForm->accept()
        line 1675 of /lib/pear/HTML/QuickForm.php: call to MoodleQuickForm->accept()
        line 435 of /lib/pear/HTML/Common.php: call to HTML_QuickForm->toHtml()
        line 204 of /lib/pear/HTML/QuickForm/DHTMLRulesTableless.php: call to HTML_Common->display()
        line 921 of /lib/formslib.php: call to HTML_QuickForm_DHTMLRulesTableless->display()
        line 314 of /course/modedit.php: call to moodleform->display()
        

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14