[MDL-45051] validate_data for events should be called only with debugdeveloper - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE
Epic Link:
Events Logging follow-up
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Master Branch:
MDL-45051-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/af8a432...MDL-45051-master
Testing Instructions:
Hide

Add following code to core\event\course_module_viewed::validate_data() (as the first line)

throw new \coding_exception('MDL-45051');

Add this config to your config file
$CFG->debug = 0;

Visit any course module that triggers the above event, ex:- Glossary

Make sure no error is seen.

Add this to your config.php
$CFG->debug = 32767;

Visit the module again and make sure an exception is thrown.
Show
Add following code to core\event\course_module_viewed::validate_data() (as the first line) throw new \coding_exception('MDL-45051'); Add this config to your config file $CFG->debug = 0; Visit any course module that triggers the above event, ex:- Glossary Make sure no error is seen. Add this to your config.php $CFG->debug = 32767; Visit the module again and make sure an exception is thrown.

Calling validate_data() is not required for production installs, it is a developer thing and should be done only when debug developer is on.

has been marked as being related by

MDL-45445 Add missing validation to events.

will be (partly) resolved by

MDL-45108 "Other" parameters should be defined in a method similar to webservices

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)