Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45059

Availability API: Should not show group options with groupmembersonly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: Conditional activities
    • Labels:
    • Testing Instructions:
      Hide

      0. The enableavailability option in advanced features must be turned on for the site.
      1. Ensure that the groupmembersonly option (under Development / Experimental features) is turned ON.
      2. On a test course, ensure there is at least one group and grouping (otherwise the buttons won't appear anyhow).
      3. Add a new Page. Expand 'Restrict access' and click 'Add restriction'.
      EXPECTED: There should NOT be a 'Group' or 'Grouping' button.
      4. Save changes. Edit settings for the new Page. Expand 'Restrict access' and click 'Add restriction' again.
      EXPECTED: Still no Group/Grouping buttons.
      5. Edit a section on the course and try 'Add restriction'.
      EXPECTED: Now there are both Group and Grouping buttons.
      6. Go into experimental settings and turn groupmembersonly OFF
      7. Back in the course, add a new Page. Try 'Add restriction'.
      EXPECTED: Now there are 'Group' and 'Grouping' buttons.
      8. Save changes. Edit settings for the new Page. Click 'Add restriction'.
      EXPECTED: Group/Grouping buttons are still available.
      9. Edit a section on the course and try 'Add restriction'.
      EXPECTED: Group/Grouping buttons are still available.

      Show
      0. The enableavailability option in advanced features must be turned on for the site. 1. Ensure that the groupmembersonly option (under Development / Experimental features) is turned ON. 2. On a test course, ensure there is at least one group and grouping (otherwise the buttons won't appear anyhow). 3. Add a new Page. Expand 'Restrict access' and click 'Add restriction'. EXPECTED: There should NOT be a 'Group' or 'Grouping' button. 4. Save changes. Edit settings for the new Page. Expand 'Restrict access' and click 'Add restriction' again. EXPECTED: Still no Group/Grouping buttons. 5. Edit a section on the course and try 'Add restriction'. EXPECTED: Now there are both Group and Grouping buttons. 6. Go into experimental settings and turn groupmembersonly OFF 7. Back in the course, add a new Page. Try 'Add restriction'. EXPECTED: Now there are 'Group' and 'Grouping' buttons. 8. Save changes. Edit settings for the new Page. Click 'Add restriction'. EXPECTED: Group/Grouping buttons are still available. 9. Edit a section on the course and try 'Add restriction'. EXPECTED: Group/Grouping buttons are still available.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-45059-master

      Description

      If groupmembersonly is turned on, the availabilty API is supposed to not allow you to restrict modules by group/grouping. (The intention is to avoid having two different ways to restrict access by group. Since groupmembersonly is still supported for now, that one takes precedence if turned on.)

      This currently only works when editing an activity and not when creating a new one. When creating a new one you can still restrict by group even if you have groupmembersonly turned on.

        Attachments

          Activity

            People

            Assignee:
            quen Sam Marshall
            Reporter:
            quen Sam Marshall
            Peer reviewer:
            Jetha Chan
            Integrator:
            Dan Poltawski
            Tester:
            Adrian Greeve
            Participants:
            Component watchers:
            Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/May/14