Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45062

Description of method result value for update_grades_return is invalid

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: Gradebook, Web Services
    • Labels:
    • Testing Instructions:
      Hide

      Same that MDL-30085

      But use this client script instead:
      https://gist.github.com/jleyva/10719337

      The script prints the upgrade_grades return information so you can verify that it works as expected and returns a numeric value:

      0 => OK,
      1 => Fail,
      2 => Updated Multiple,
      4 => Locked

      (Yes, 0 means OK and 3 is missing, see lib/grade/constans.php)

      Show
      Same that MDL-30085 But use this client script instead: https://gist.github.com/jleyva/10719337 The script prints the upgrade_grades return information so you can verify that it works as expected and returns a numeric value: 0 => OK, 1 => Fail, 2 => Updated Multiple, 4 => Locked (Yes, 0 means OK and 3 is missing, see lib/grade/constans.php)
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      It should return just an external value, currently is returning a single structure

      Unit tests works since the function is called directly without the ws wrapper that checks for correct input/output values

      The easy way to ix that is to change the result format for that function

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jleyva Juan Leyva
              Reporter:
              jleyva Juan Leyva
              Peer reviewer:
              Sam Hemelryk
              Integrator:
              Damyon Wiese
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14