Loading...

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
git://github.com/jleyva/moodle.git
Pull Main Branch:
~~MDL-45062~~
Pull Main Diff URL:
https://github.com/jleyva/moodle/compare/master...MDL-45062
Testing Instructions:

Hide

Same that ~~MDL-30085~~

But use this client script instead:
https://gist.github.com/jleyva/10719337

The script prints the upgrade_grades return information so you can verify that it works as expected and returns a numeric value:

0 => OK,
1 => Fail,
2 => Updated Multiple,
4 => Locked

(Yes, 0 means OK and 3 is missing, see lib/grade/constans.php)

Show
Same that MDL-30085 But use this client script instead: https://gist.github.com/jleyva/10719337 The script prints the upgrade_grades return information so you can verify that it works as expected and returns a numeric value: 0 => OK, 1 => Fail, 2 => Updated Multiple, 4 => Locked (Yes, 0 means OK and 3 is missing, see lib/grade/constans.php)

It should return just an external value, currently is returning a single structure

Unit tests works since the function is called directly without the ws wrapper that checks for correct input/output values

The easy way to ix that is to change the result format for that function

Discovered while testing

MDL-45131 Some external functions tests don't validate returned parameters

Participants:: Ankit Agarwal, CiBoT, Damyon Wiese, Eloy Lafuente (stronk7), Juan Leyva, Sam Hemelryk