Loading...

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Main Branch:
~~MDL-45074~~-master
Pull Main Diff URL:
https://github.com/ankitagarwal/moodle/compare/af8a432...MDL-45074-master
Testing Instructions:
Hide

Enable standard logstore

Create a feedback activity with setting "Record usernames" as "Anonymous"

Submit a response as a student.

Goto My home ► Site administration ► Reports ► Live logs as admin

View logs using standard logstore. Make sure you don't see logs for the feedback submission.
Show
Enable standard logstore Create a feedback activity with setting "Record usernames" as "Anonymous" Submit a response as a student. Goto My home ► Site administration ► Reports ► Live logs as admin View logs using standard logstore. Make sure you don't see logs for the feedback submission.

        // Set up filtering.

        if (!empty($this->filterparams->courseid)) {

            $joins[] = "courseid = :courseid";

            $params['courseid'] = $this->filterparams->courseid;

        if (!empty($this->filterparams->date)) {

            $joins[] = "timecreated > :date";

            $params['date'] = $this->filterparams->date;

        if (!empty($this->filterparams->date)) {

            $joins[] = "anonymous = :anon";

            $params['anon'] = $this->filterparams->anonymous;

Simple copy-pasting error. Needs to be fixed and tested.

is a regression caused by

MDL-43682 Rewrite loglive report to use the new logging api

Testing discovered

MDL-44998 Review indexes in standard log table

MDL-45087 Report log should not show anonymous events.

Participants:: Ankit Agarwal, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Jetha Chan, Marina Glancy, Petr Skoda