Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45074

report_loglive is not working with 'anonymous users'

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: Reports
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable standard logstore
      2. Create a feedback activity with setting "Record usernames" as "Anonymous"
      3. Submit a response as a student.
      4. Goto My home ► Site administration ► Reports ► Live logs as admin
      5. View logs using standard logstore. Make sure you don't see logs for the feedback submission.
      Show
      Enable standard logstore Create a feedback activity with setting "Record usernames" as "Anonymous" Submit a response as a student. Goto My home ► Site administration ► Reports ► Live logs as admin View logs using standard logstore. Make sure you don't see logs for the feedback submission.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-45074-master

      Description

      The following code found
      https://github.com/moodle/moodle/blob/master/report/loglive/classes/table_log.php#L322

              // Set up filtering.
              if (!empty($this->filterparams->courseid)) {
                  $joins[] = "courseid = :courseid";
                  $params['courseid'] = $this->filterparams->courseid;
              }
       
              if (!empty($this->filterparams->date)) {
                  $joins[] = "timecreated > :date";
                  $params['date'] = $this->filterparams->date;
              }
       
              if (!empty($this->filterparams->date)) {
                  $joins[] = "anonymous = :anon";
                  $params['anon'] = $this->filterparams->anonymous;
              }
      

      Simple copy-pasting error. Needs to be fixed and tested.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Petr Skoda
              Integrator:
              Dan Poltawski
              Tester:
              Jetha Chan
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14