Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45096

JS error in some themes when admin block hidden

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Against at least the following themes:

      • clean
      • canvas
      • base
      1. Hide the administration block on the home page
      2. view the front page
        • Confirm that there were no JS errors in the console
      Show
      Against at least the following themes: clean canvas base Hide the administration block on the home page view the front page Confirm that there were no JS errors in the console
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-45096-master

      Description

      On some themes on MOODLE_26_STABLE, this code fails due to siteadminbranch.node being null, breaking all block configuration and other features.

      I placed the code that uses siteadminbranch.node in a block after testing presence of that property and all seemed to work fine.

        Attachments

          Activity

            People

            • Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              mrclay Steve Clay
              Peer reviewer:
              Petr Skoda
              Integrator:
              Sam Hemelryk
              Tester:
              John Okely
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Jake Dallimore, Jun Pataleta, Jake Dallimore, Jun Pataleta
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14