Moodle
  1. Moodle
  2. MDL-45116

Workshop submission title displays behind author picture

    Details

      Description

      To see the problem you will need to view a submission to a workshop. At the top of the submission there is a header with a picture of the author, the title of the submission, and some other metadata. Currently the title of the submission is displayed behind the picture.

      In the CSS for the workshop there is a class called 'title' that appears to be intended to indent the title appropriately, but the class is not being applied in the renderer.

        Gliffy Diagrams

        1. correct.png
          29 kB
        2. incorrect.png
          27 kB

          Issue Links

            Activity

            Hide
            David Mudrak added a comment -

            This seems to be a regression caused by MDL-41622 where the CSS class 'title' was removed from that element. I need to check yet what the reason for removing it was.

            Show
            David Mudrak added a comment - This seems to be a regression caused by MDL-41622 where the CSS class 'title' was removed from that element. I need to check yet what the reason for removing it was.
            Hide
            David Mudrak added a comment -

            Also note, Moodle 2.6 could be affected as well by this.

            Show
            David Mudrak added a comment - Also note, Moodle 2.6 could be affected as well by this.
            Hide
            David Mudrak added a comment -

            I knew this was not completely new to me - see MDL-44649 for the duplicate report.

            Show
            David Mudrak added a comment - I knew this was not completely new to me - see MDL-44649 for the duplicate report.
            Hide
            David Mudrak added a comment -

            Kevin Wiliarty can you please prepare a branch for MOODLE_26_STABLE as well and submit the issue for peer-review please? I would give it +1 and pass for integration. Thanks.

            Show
            David Mudrak added a comment - Kevin Wiliarty can you please prepare a branch for MOODLE_26_STABLE as well and submit the issue for peer-review please? I would give it +1 and pass for integration. Thanks.
            Hide
            Kevin Wiliarty added a comment -

            Sorry I missed the existing ticket. I did try to find one. Thanks for linking things up, and I can get the 2.6 branch out in a jiff.

            Show
            Kevin Wiliarty added a comment - Sorry I missed the existing ticket. I did try to find one. Thanks for linking things up, and I can get the 2.6 branch out in a jiff.
            Hide
            Kevin Wiliarty added a comment -

            The 2.6 branch is ready.

            Show
            Kevin Wiliarty added a comment - The 2.6 branch is ready.
            Hide
            David Mudrak added a comment -

            Thanks for locating the regression and preparing the patch. +1 for landing.

            Show
            David Mudrak added a comment - Thanks for locating the regression and preparing the patch. +1 for landing.
            Hide
            David Mudrak added a comment -

            Submitting for integration.

            Show
            David Mudrak added a comment - Submitting for integration.
            Hide
            Sam Hemelryk added a comment -

            Thanks Kevin this has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Kevin this has been integrated now.
            Hide
            Sam Hemelryk added a comment -

            Tested and passed during integration review.

            Show
            Sam Hemelryk added a comment - Tested and passed during integration review.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Closing this as fixed, now it's part of Moodle upstream! Thanks!

            And in the end,
            it's not the years in your life that count,
            it's the life in your years.

            ~ Abraham Lincoln ~

            Show
            Eloy Lafuente (stronk7) added a comment - Closing this as fixed, now it's part of Moodle upstream! Thanks! And in the end, it's not the years in your life that count, it's the life in your years. ~ Abraham Lincoln ~

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: