Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45131

Some external functions tests don't validate returned parameters

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      The only way to test this is to verify that the unit tests are working for this files:
      files/tests/externallib_test.php
      user/tests/externallib_test.php
      calendar/tests/externallib_test.php
      cohort/tests/externallib_test.php
      course/tests/externallib_test.php
      enrol/self/tests/externallib_test.php
      enrol/tests/externallib_test.php
      message/output/airnotifier/tests/externallib_test.php

      Show
      The only way to test this is to verify that the unit tests are working for this files: files/tests/externallib_test.php user/tests/externallib_test.php calendar/tests/externallib_test.php cohort/tests/externallib_test.php course/tests/externallib_test.php enrol/self/tests/externallib_test.php enrol/tests/externallib_test.php message/output/airnotifier/tests/externallib_test.php
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45131-master

      Description

      As mentioned by Damyon, external_api::clean_returnvalue() must be used for validating data returned by a webservice call in all web services unit tests

      Currently, some web services unit tests in core_users, core_files, core_grading and some more don't perform this check

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jleyva Juan Leyva
              Reporter:
              jleyva Juan Leyva
              Peer reviewer:
              Dani Palou
              Integrator:
              David Monllaó
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15