[MDL-45131] Some external functions tests don't validate returned parameters - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.6.2, 2.9
Fix Version/s: 2.7.8, 2.8.6
Component/s: Unit tests, Web Services
Labels:
- ci
- triaged

Affected Branches:
MOODLE_26_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/jleyva/moodle.git
Pull Master Branch:
~~MDL-45131~~-master
Pull Master Diff URL:
https://github.com/jleyva/moodle/compare/d755125...MDL-45131-master
Testing Instructions:

Hide

The only way to test this is to verify that the unit tests are working for this files:
files/tests/externallib_test.php
user/tests/externallib_test.php
calendar/tests/externallib_test.php
cohort/tests/externallib_test.php
course/tests/externallib_test.php
enrol/self/tests/externallib_test.php
enrol/tests/externallib_test.php
message/output/airnotifier/tests/externallib_test.php

Show
The only way to test this is to verify that the unit tests are working for this files: files/tests/externallib_test.php user/tests/externallib_test.php calendar/tests/externallib_test.php cohort/tests/externallib_test.php course/tests/externallib_test.php enrol/self/tests/externallib_test.php enrol/tests/externallib_test.php message/output/airnotifier/tests/externallib_test.php

Description

As mentioned by Damyon, external_api::clean_returnvalue() must be used for validating data returned by a webservice call in all web services unit tests

Currently, some web services unit tests in core_users, core_files, core_grading and some more don't perform this check

Attachments

Issue Links

Testing discovered

MDL-45062 Description of method result value for update_grades_return is invalid

Closed

MDL-49837 Fix mod_assign external function tests (missing return parameters cleaning and invalid checks)

Closed

Activity

People

Assignee:: Juan Leyva

Reporter:: Juan Leyva

Peer reviewer:: Dani Palou

Integrator:: David Monllaó

Tester:: Simey Lameze

Participants:: CiBoT, Dani Palou, Dan Poltawski, David Monllaó, Juan Leyva, Simey Lameze

Component watchers:: Juan Leyva, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 17/Apr/14 1:14 AM

Updated:: 18/Apr/15 3:54 AM

Resolved:: 18/Apr/15 3:54 AM

Fix Release Date:: 11/May/15