Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45131

Some external functions tests don't validate returned parameters

    XMLWordPrintable

Details

    • MOODLE_26_STABLE, MOODLE_29_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MDL-45131-master
    • Hide

      The only way to test this is to verify that the unit tests are working for this files:
      files/tests/externallib_test.php
      user/tests/externallib_test.php
      calendar/tests/externallib_test.php
      cohort/tests/externallib_test.php
      course/tests/externallib_test.php
      enrol/self/tests/externallib_test.php
      enrol/tests/externallib_test.php
      message/output/airnotifier/tests/externallib_test.php

      Show
      The only way to test this is to verify that the unit tests are working for this files: files/tests/externallib_test.php user/tests/externallib_test.php calendar/tests/externallib_test.php cohort/tests/externallib_test.php course/tests/externallib_test.php enrol/self/tests/externallib_test.php enrol/tests/externallib_test.php message/output/airnotifier/tests/externallib_test.php

    Description

      As mentioned by Damyon, external_api::clean_returnvalue() must be used for validating data returned by a webservice call in all web services unit tests

      Currently, some web services unit tests in core_users, core_files, core_grading and some more don't perform this check

      Attachments

        Issue Links

          Activity

            People

              jleyva Juan Leyva
              jleyva Juan Leyva
              Dani Palou Dani Palou
              David Monllaó David Monllaó
              Simey Lameze Simey Lameze
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15