Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45144

Replace remaining add_to_log() calls in mod_book

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.7
    • Component/s: Book
    • Labels:

      Description

      grep is your friend

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            damyon Damyon Wiese added a comment -

            there are no behat tests for book

            Show
            damyon Damyon Wiese added a comment - there are no behat tests for book
            Hide
            damyon Damyon Wiese added a comment -

            There are currently 4 passed qa tests that will need to be reset when this is integrated.

            Show
            damyon Damyon Wiese added a comment - There are currently 4 passed qa tests that will need to be reset when this is integrated.
            Hide
            skodak Petr Skoda added a comment -

            oops, test instructions fixed

            Show
            skodak Petr Skoda added a comment - oops, test instructions fixed
            Hide
            damyon Damyon Wiese added a comment -

            I guess it's debatable whether set_legacy_log_data needs to be deprecated properly - it was a public method in 2.6 - but this plugin does not support sub-plugins so nothing else should really have been calling it.

            Everything else looks fine to me.

            Please comment on the deprecation - then this looks fine for integration.

            Show
            damyon Damyon Wiese added a comment - I guess it's debatable whether set_legacy_log_data needs to be deprecated properly - it was a public method in 2.6 - but this plugin does not support sub-plugins so nothing else should really have been calling it. Everything else looks fine to me. Please comment on the deprecation - then this looks fine for integration.
            Hide
            skodak Petr Skoda added a comment -

            yes, I was thinking about the set_legacylogdata too, but then decided that the BC is not worth polluting the codebase there. Thanks a lot, submitting for integration.

            Show
            skodak Petr Skoda added a comment - yes, I was thinking about the set_legacylogdata too, but then decided that the BC is not worth polluting the codebase there. Thanks a lot, submitting for integration.
            Hide
            marina Marina Glancy added a comment -

            Thanks Petr, integrated in master

            book-related QA tests need to be reset too

            Show
            marina Marina Glancy added a comment - Thanks Petr, integrated in master book-related QA tests need to be reset too
            Hide
            marina Marina Glancy added a comment -

            Tested in integration

            Show
            marina Marina Glancy added a comment - Tested in integration
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Closing this as fixed, now it's part of Moodle upstream! Thanks!

            And in the end,
            it's not the years in your life that count,
            it's the life in your years.

            ~ Abraham Lincoln ~

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Closing this as fixed, now it's part of Moodle upstream! Thanks! And in the end, it's not the years in your life that count, it's the life in your years. ~ Abraham Lincoln ~

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14