Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45171

Non-oracle friendly queries in logging

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.7
    • 2.7
    • Logging

    Description

      Steps to reproduce:

      • Run behat with --tags=@report on oracle

      Expected results:
      They pass 100%

      Actual results:
      18 scenarios (11 passed, 7 failed)

      ::) failed steps (::)
       
      01. Moodle exception: Error reading from database More information about this error
       
          Debug info:
           ORA-00933: SQL command not properly ended
          SELECT c.id,c.shortname , ctx.id AS ctxid, ctx.path AS ctxpath, ctx.depth AS ctxdepth, ctx.contextlevel AS ctxlevel, ctx.instanceid AS ctxinstance FROM ecourse as c
                             LEFT JOIN econtext ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :o_contextlevel)
                               WHERE c.id = :o_param7
          [array (
            'o_contextlevel' => 50,
            'o_param7' => '2',
          )]
          Error code: dmlreadexception
       
          Stack trace:
       
          line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
          line 271 of /lib/dml/oci_native_moodle_database.php: call to moodle_database->query_end()
          line 1127 of /lib/dml/oci_native_moodle_database.php: call to oci_native_moodle_database->query_end()
          line 488 of /report/log/classes/table_log.php: call to oci_native_moodle_database->get_records_sql()
          line 434 of /report/log/classes/table_log.php: call to report_log_table_log->update_users_and_courses_used()
          line 1495 of /lib/tablelib.php: call to report_log_table_log->query_db()
          line 50 of /report/log/classes/renderer.php: call to table_sql->out()
          line 221 of /lib/outputrenderers.php: call to report_log_renderer->render_report_log_renderable()
          line 172 of /report/log/index.php: call to plugin_renderer_base->render()
          In step `And I press "Get these logs"'.                               # behat_forms::press_button()
          From scenario `Filter log report for standard and legacy log reader'. # /Users/danp/moodles/im_behating/moodle/report/log/tests/behat/filter_log.feature:21
          Of feature `In a report, admin can filter log data'.                  # /Users/danp/moodles/im_behating/moodle/report/log/tests/behat/filter_log.feature
       
      02. Moodle exception: Error reading from database More information about this error
       
          Debug info:
           ORA-00933: SQL command not properly ended
          SELECT c.id,c.shortname , ctx.id AS ctxid, ctx.path AS ctxpath, ctx.depth AS ctxdepth, ctx.contextlevel AS ctxlevel, ctx.instanceid AS ctxinstance FROM ecourse as c
                             LEFT JOIN econtext ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :o_contextlevel)
                               WHERE c.id = :o_param7
          [array (
            'o_contextlevel' => 50,
            'o_param7' => '2',
          )]
          Error code: dmlreadexception
       
          Stack trace:
       
          line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
          line 271 of /lib/dml/oci_native_moodle_database.php: call to moodle_database->query_end()
          line 1127 of /lib/dml/oci_native_moodle_database.php: call to oci_native_moodle_database->query_end()
          line 488 of /report/log/classes/table_log.php: call to oci_native_moodle_database->get_records_sql()
          line 434 of /report/log/classes/table_log.php: call to report_log_table_log->update_users_and_courses_used()
          line 1495 of /lib/tablelib.php: call to report_log_table_log->query_db()
          line 50 of /report/log/classes/renderer.php: call to table_sql->out()
          line 221 of /lib/outputrenderers.php: call to report_log_renderer->render_report_log_renderable()
          line 172 of /report/log/index.php: call to plugin_renderer_base->render()
          In step `And I press "Get these logs"'.                               # behat_forms::press_button()
          From scenario `Filter log report for standard log reader'.            # /Users/danp/moodles/im_behating/moodle/report/log/tests/behat/filter_log.feature:46
          Of feature `In a report, admin can filter log data'.                  # /Users/danp/moodles/im_behating/moodle/report/log/tests/behat/filter_log.feature
       
      03. Moodle exception: Error reading from database More information about this error
       
          Debug info:
           ORA-00933: SQL command not properly ended
          SELECT c.id,c.shortname , ctx.id AS ctxid, ctx.path AS ctxpath, ctx.depth AS ctxdepth, ctx.contextlevel AS ctxlevel, ctx.instanceid AS ctxinstance FROM ecourse as c
                             LEFT JOIN econtext ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :o_contextlevel)
                               WHERE c.id = :o_param7
          [array (
            'o_contextlevel' => 50,
            'o_param7' => '2',
          )]
          Error code: dmlreadexception
       
          Stack trace:
       
          line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
          line 271 of /lib/dml/oci_native_moodle_database.php: call to moodle_database->query_end()
          line 1127 of /lib/dml/oci_native_moodle_database.php: call to oci_native_moodle_database->query_end()
          line 488 of /report/log/classes/table_log.php: call to oci_native_moodle_database->get_records_sql()
          line 434 of /report/log/classes/table_log.php: call to report_log_table_log->update_users_and_courses_used()
          line 1495 of /lib/tablelib.php: call to report_log_table_log->query_db()
          line 50 of /report/log/classes/renderer.php: call to table_sql->out()
          line 221 of /lib/outputrenderers.php: call to report_log_renderer->render_report_log_renderable()
          line 172 of /report/log/index.php: call to plugin_renderer_base->render()
          In step `And I press "Get these logs"'.                               # behat_forms::press_button()
          From scenario `Filter log report for legacy log reader'.              # /Users/danp/moodles/im_behating/moodle/report/log/tests/behat/filter_log.feature:61
          Of feature `In a report, admin can filter log data'.                  # /Users/danp/moodles/im_behating/moodle/report/log/tests/behat/filter_log.feature
       
      04. Moodle exception: Error reading from database More information about this error
       
          Debug info:
           ORA-00933: SQL command not properly ended
          SELECT c.id,c.shortname , ctx.id AS ctxid, ctx.path AS ctxpath, ctx.depth AS ctxdepth, ctx.contextlevel AS ctxlevel, ctx.instanceid AS ctxinstance FROM ecourse as c
                             LEFT JOIN econtext ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :o_contextlevel)
                               WHERE c.id = :o_param8
          [array (
            'o_contextlevel' => 50,
            'o_param8' => '2',
          )]
          Error code: dmlreadexception
       
          Stack trace:
       
          line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
          line 271 of /lib/dml/oci_native_moodle_database.php: call to moodle_database->query_end()
          line 1127 of /lib/dml/oci_native_moodle_database.php: call to oci_native_moodle_database->query_end()
          line 488 of /report/log/classes/table_log.php: call to oci_native_moodle_database->get_records_sql()
          line 434 of /report/log/classes/table_log.php: call to report_log_table_log->update_users_and_courses_used()
          line 1495 of /lib/tablelib.php: call to report_log_table_log->query_db()
          line 50 of /report/log/classes/renderer.php: call to table_sql->out()
          line 221 of /lib/outputrenderers.php: call to report_log_renderer->render_report_log_renderable()
          line 106 of /report/log/user.php: call to plugin_renderer_base->render()
          In step `When I navigate to "Today's logs" node in "Profile settings for Student 1 > Activity reports"'. # behat_navigation::i_navigate_to_node_in()
          From scenario `View Todays' and all log report for user'.                                                # /Users/danp/moodles/im_behating/moodle/report/log/tests/behat/user_log.feature:38
          Of feature `User can view activity log.'.                                                                # /Users/danp/moodles/im_behating/moodle/report/log/tests/behat/user_log.feature
       
      05. Moodle exception: Error reading from database More information about this error
       
          Debug info:
           ORA-00933: SQL command not properly ended
          SELECT c.id,c.shortname , ctx.id AS ctxid, ctx.path AS ctxpath, ctx.depth AS ctxdepth, ctx.contextlevel AS ctxlevel, ctx.instanceid AS ctxinstance FROM ecourse as c
                             LEFT JOIN econtext ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :o_contextlevel)
                               WHERE c.id = :o_param7
          [array (
            'o_contextlevel' => 50,
            'o_param7' => '2',
          )]
          Error code: dmlreadexception
       
          Stack trace:
       
          line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
          line 271 of /lib/dml/oci_native_moodle_database.php: call to moodle_database->query_end()
          line 1127 of /lib/dml/oci_native_moodle_database.php: call to oci_native_moodle_database->query_end()
          line 394 of /report/loglive/classes/table_log.php: call to oci_native_moodle_database->get_records_sql()
          line 340 of /report/loglive/classes/table_log.php: call to report_loglive_table_log->update_users_and_courses_used()
          line 1495 of /lib/tablelib.php: call to report_loglive_table_log->query_db()
          line 98 of /report/loglive/classes/renderer.php: call to table_sql->out()
          line 49 of /report/loglive/classes/renderer.php: call to report_loglive_renderer->render_table()
          line 221 of /lib/outputrenderers.php: call to report_loglive_renderer->render_report_loglive_renderable()
          line 90 of /report/loglive/index.php: call to plugin_renderer_base->render()
          In step `Given I navigate to "Live logs" node in "Site administration > Reports"'.                          # behat_navigation::i_navigate_to_node_in()
          From scenario `Check loglive report entries and make sure the report works for standard and legacy reader'. # /Users/danp/moodles/im_behating/moodle/report/loglive/tests/behat/loglive_report.feature:24
          Of feature `In a report, admin can see loglive data'.                                                       # /Users/danp/moodles/im_behating/moodle/report/loglive/tests/behat/loglive_report.feature
       
      06. Moodle exception: Error reading from database More information about this error
       
          Debug info:
           ORA-00933: SQL command not properly ended
          SELECT c.id,c.shortname , ctx.id AS ctxid, ctx.path AS ctxpath, ctx.depth AS ctxdepth, ctx.contextlevel AS ctxlevel, ctx.instanceid AS ctxinstance FROM ecourse as c
                             LEFT JOIN econtext ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :o_contextlevel)
                               WHERE c.id = :o_param7
          [array (
            'o_contextlevel' => 50,
            'o_param7' => '2',
          )]
          Error code: dmlreadexception
       
          Stack trace:
       
          line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
          line 271 of /lib/dml/oci_native_moodle_database.php: call to moodle_database->query_end()
          line 1127 of /lib/dml/oci_native_moodle_database.php: call to oci_native_moodle_database->query_end()
          line 394 of /report/loglive/classes/table_log.php: call to oci_native_moodle_database->get_records_sql()
          line 340 of /report/loglive/classes/table_log.php: call to report_loglive_table_log->update_users_and_courses_used()
          line 1495 of /lib/tablelib.php: call to report_loglive_table_log->query_db()
          line 98 of /report/loglive/classes/renderer.php: call to table_sql->out()
          line 49 of /report/loglive/classes/renderer.php: call to report_loglive_renderer->render_table()
          line 221 of /lib/outputrenderers.php: call to report_loglive_renderer->render_report_loglive_renderable()
          line 90 of /report/loglive/index.php: call to plugin_renderer_base->render()
          In step `When I navigate to "Live logs" node in "Site administration > Reports"'.                                                   # behat_navigation::i_navigate_to_node_in()
          From scenario `Check loglive report entries and make sure the pause/resume button works for standard reader along with ajax calls'. # /Users/danp/moodles/im_behating/moodle/report/loglive/tests/behat/loglive_report.feature:35
          Of feature `In a report, admin can see loglive data'.                                                                               # /Users/danp/moodles/im_behating/moodle/report/loglive/tests/behat/loglive_report.feature
       
      07. Moodle exception: Error reading from database More information about this error
       
          Debug info:
           ORA-00933: SQL command not properly ended
          SELECT c.id,c.shortname , ctx.id AS ctxid, ctx.path AS ctxpath, ctx.depth AS ctxdepth, ctx.contextlevel AS ctxlevel, ctx.instanceid AS ctxinstance FROM ecourse as c
                             LEFT JOIN econtext ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :o_contextlevel)
                               WHERE c.id = :o_param7
          [array (
            'o_contextlevel' => 50,
            'o_param7' => '2',
          )]
          Error code: dmlreadexception
       
          Stack trace:
       
          line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
          line 271 of /lib/dml/oci_native_moodle_database.php: call to moodle_database->query_end()
          line 1127 of /lib/dml/oci_native_moodle_database.php: call to oci_native_moodle_database->query_end()
          line 394 of /report/loglive/classes/table_log.php: call to oci_native_moodle_database->get_records_sql()
          line 340 of /report/loglive/classes/table_log.php: call to report_loglive_table_log->update_users_and_courses_used()
          line 1495 of /lib/tablelib.php: call to report_loglive_table_log->query_db()
          line 98 of /report/loglive/classes/renderer.php: call to table_sql->out()
          line 49 of /report/loglive/classes/renderer.php: call to report_loglive_renderer->render_table()
          line 221 of /lib/outputrenderers.php: call to report_loglive_renderer->render_report_loglive_renderable()
          line 90 of /report/loglive/index.php: call to plugin_renderer_base->render()
          In step `When I navigate to "Live logs" node in "Site administration > Reports"'.                                                   # behat_navigation::i_navigate_to_node_in()
          From scenario `Check loglive report entries and make sure the pause/resume button works for legacy reader along with ajax calls'.   # /Users/danp/moodles/im_behating/moodle/report/loglive/tests/behat/loglive_report.feature:58
          Of feature `In a report, admin can see loglive data'.                                                                               # /Users/danp/moodles/im_behating/moodle/report/loglive/tests/behat/loglive_report.feature
      

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/May/14