Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45226

Pages with drag/drop are broken for touch devices

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Difficulty level: Cumbersome

      Important points
      • This MUST be tested on all supported browsers and specifically a range of mouse and touch devices, at least:
        • IE
        • Firefox
        • Chrome
        • Safari
        • iOS Safari
        • iOS Chrome
        • Android Stock
        • Android Chrome
      • You MUST test with (only needs to be done once or twice, not for every browser combination):
        • CDN loading enabled and disabled
        • Combo loading enabled and disabled
      Instructions
      1. Open a course
      2. Turn editing on
      3. Try moving the page
        • For mouse-based devices with the mouse
        • For touch devices drag/drop with a finger*
        • for devices which support fingers and mice, do both!*
      4. Confirm that the page moves
      5. Open the activity chooser
      6. Confirm that you can drag it around the screen by it's title area
      7. Close it
      8. Try moving the page again
      9. Confirm that the page moves

      Note: The Touch emulation on some builds of Chrome and Chrome Android seems to be broken at the moment (fixed on Canary). This is a bug with the browsers, not YUI.

      Show
      Difficulty level: Cumbersome Important points This MUST be tested on all supported browsers and specifically a range of mouse and touch devices , at least: IE Firefox Chrome Safari iOS Safari iOS Chrome Android Stock Android Chrome You MUST test with (only needs to be done once or twice, not for every browser combination): CDN loading enabled and disabled Combo loading enabled and disabled Instructions Open a course Turn editing on Try moving the page For mouse-based devices with the mouse For touch devices drag/drop with a finger* for devices which support fingers and mice, do both!* Confirm that the page moves Open the activity chooser Confirm that you can drag it around the screen by it's title area Close it Try moving the page again Confirm that the page moves Note: The Touch emulation on some builds of Chrome and Chrome Android seems to be broken at the moment (fixed on Canary). This is a bug with the browsers, not YUI.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-45226-master

      Description

      I was hoping that upstream YUI would have had a chance to look at this patch before-hand, but I guess tilo is busy on other projects at the moment.

      There's a rather serious breakage whereby if drag/drop is enabled on a page then all gesturestart events have the default action prevented. Sadly this was something introduced in a long series of bugs by us trying to get dd to work at all on Android. I have got a patch and I've tested it extensively, but I was hoping that Tilo Mitra at Y! would have had a chance to look at it too.

        Attachments

          Activity

            People

            • Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Petr Skoda
              Integrator:
              Dan Poltawski
              Tester:
              John Okely
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14