Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45236

Incorrect patch in MDL-45119 for 2.5

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.5
    • Fix Version/s: 2.5.6
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Edit /help_ajax.php to add the following immediately before the json_encode() line.

        throw new moodle_exception('foo', 'bar', new moodle_url('/foo'));
        

      2. Open the login page
      3. Click the help icon
        • Confirm that the exception was displayed correctly with link displayed normally
      Show
      Edit /help_ajax.php to add the following immediately before the json_encode() line. throw new moodle_exception('foo', 'bar', new moodle_url('/foo')); Open the login page Click the help icon Confirm that the exception was displayed correctly with link displayed normally
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE

      Description

      Oops - MDL-45119 was merged with the path before the review comments. I guess I screwed up and failed to push properly.
      Affects 2.5 only.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Petr Skoda
              Integrator:
              Dan Poltawski
              Tester:
              Jason Fowler
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14