Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45280

Unexpected settings being shown on install/upgrade

    Details

    • Testing Instructions:
      Hide

      Test 1:

      1. Repeat testing instructions from MDL-45134

      Test 2:

      1. Make sure that behat tests pass (re-initialise them before testing)

      Test 3:

      1. Install new site
      2. Make sure that clicking on Site Administration > Notifications does not display any new settings
      3. Check that AnnotatePDF is filled with default stamps (2.6 and 2.7)
      4. Check that More has default background (2.7)
      Show
      Test 1: Repeat testing instructions from MDL-45134 Test 2: Make sure that behat tests pass (re-initialise them before testing) Test 3: Install new site Make sure that clicking on Site Administration > Notifications does not display any new settings Check that AnnotatePDF is filled with default stamps (2.6 and 2.7) Check that More has default background (2.7)
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-45280-master

      Description

      This seems to be a regression of MDL-45134.

      It has been detected that some settings and being shown on install/upgrade when they should not. Easily reproducible by:

      1) running some behat tests (more info below).
      2) installing a site from scratch, the unexpected settings are shown in the "site settings" page, together with the usual site name, description... ones.

      It seems that they are always the same 4 settings, all them being file manager settings:

      • assignfeedback_editpdf | stamps
      • theme_clean | logo
      • theme_more | backgroundimage
      • theme_more | logo

      Adding some extra info:

      • Behat run, showing all the failures:

      vendor/bin/behat --config /Users/stronk7/Sites/moodle_data_gittesting/master/postgres_behat/behat/behat.yml --tags='~@javascript'
      Moodle 2.7beta+ (Build: 20140424), pgsql, 83ddacfff7cf45727f4ac6f6e983b5f8686b91b5
      Server OS "Darwin", Browser: "firefox"
      Started at 26-04-2014, 02:22
      ....F---------------------------------------------------....F--------- 70
      --------------------------------------------.......................... 140
      ...................................................................... 210
      ...................................................................... 280
      ...................................................................... 350
      ...................................................................... 420
      ...................................................................... 490
      ...................................................................... 560
      ...................................................................... 630
      .........................................................F------------ 700
      -----................................................................. 770
      ...................................................................... 840
      .......................................F-------------------........... 910
      ...................................................................... 980
      ...................................................................... 1050
      ...................................................................... 1120
      .........................................F---------------------------- 1190
      --------------------------------------................................ 1260
      ..........................F----....................................... 1330
      ...................................................................... 1400
      ................................................................ls
      ...... 1470
      ................................................F---------.......F---- 1540
      ------------------........F------------------------------------------- 1610
      --------........F--------------........F------------------------------ 1680
      -------........F-------........F------........F---........F------..... 1750
      .F---.......F-------.......F-------.......F---------.......F---------. 1820
      ......F-------.......F-------.......F--------------------------------- 1890
      -------........F---------------------------------------........F------ 1960
      ------------........F-----........F----------------------------....... 2030
      ...................................................................... 2100
      ...................................................................... 2170
      ...................................................................... 2240
      ...................................................................... 2310
      ...................................................................... 2380
      ...............................................F-----------........F-- 2450
      ---------........F-----------........F------------------.......F------ 2520
      --------........F----------------........F----------------------...... 2590
      ...................................................................... 2660
      ...................................................................... 2730
      ...................................................................... 2800
      ...................................................................... 2870
      ...................................................................... 2940
      ...................................................................... 3010
      ............................................
       
      (::) Pasos fallidos (::)
       
      01. Top navigation node "Site administration not found in "
          In step `And I navigate to "Manage activities" node in "Site administration > Plugins > Activity modules"'. # behat_navigation::i_navigate_to_node_in()
          From scenario background.                                                                                   # /Users/stronk7/git_moodle/testing/blocks/activity_modules/tests/behat/block_activity_modules.feature:7
          Of feature `Block activity modules'.                                                                        # /Users/stronk7/git_moodle/testing/blocks/activity_modules/tests/behat/block_activity_modules.feature
       
      02. Top navigation node "Site administration not found in "
          In step `And I navigate to "Manage activities" node in "Site administration > Plugins > Activity modules"'. # behat_navigation::i_navigate_to_node_in()
          From scenario background.                                                                                   # /Users/stronk7/git_moodle/testing/blocks/activity_modules/tests/behat/block_activity_modules.feature:7
          Of feature `Block activity modules'.                                                                        # /Users/stronk7/git_moodle/testing/blocks/activity_modules/tests/behat/block_activity_modules.feature
       
      03. Link matching locator "'Site policies'" not found.
          In step `And I follow "Site policies"'.                                                                     # behat_general::click_link()
          From scenario background.                                                                                   # /Users/stronk7/git_moodle/testing/mod/forum/tests/behat/edit_post_student.feature:7
          Of feature `Students can edit or delete their forum posts within a set time limit'.                         # /Users/stronk7/git_moodle/testing/mod/forum/tests/behat/edit_post_student.feature
       
      04. Link matching locator "'Manage tags'" not found.
          In step `And I follow "Manage tags"'.                                                                       # behat_general::click_link()
          From scenario `Wiki page edition of official tags works as expected'.                                       # /Users/stronk7/git_moodle/testing/mod/wiki/tests/behat/edit_tags.feature:45
          Of feature `Edited wiki pages handle tags correctly'.                                                       # /Users/stronk7/git_moodle/testing/mod/wiki/tests/behat/edit_tags.feature
       
      05. Link matching locator "'Manage tags'" not found.
          In step `And I follow "Manage tags"'.                                                                       # behat_general::click_link()
          From scenario background.                                                                                   # /Users/stronk7/git_moodle/testing/admin/tool/behat/tests/behat/get_and_set_fields.feature:7
          Of feature `Verify that all form fields values can be get and set'.                                         # /Users/stronk7/git_moodle/testing/admin/tool/behat/tests/behat/get_and_set_fields.feature
       
      06. Xpath matching locator "//div[@id='settingsnav']/descendant::li[contains(concat(' ', normalize-space(@class), ' '), ' type_setting ')][contains(., 'Appearance')]" not found.
          In step `And I click on "Courses" "link" in the "//div[@id='settingsnav']/descendant::li[contains(concat(' ', normalize-space(@class), ' '), ' type_setting ')][contains(., 'Appearance')]" "xpath_element"'. # behat_general::i_click_on_in_the()
          From scenario `Courses list with extended course names'.                                                                                                                                                      # /Users/stronk7/git_moodle/testing/admin/tests/behat/display_short_names.feature:17
          Of feature `Display extended course names'.                                                                                                                                                                   # /Users/stronk7/git_moodle/testing/admin/tests/behat/display_short_names.feature
       
      07. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test making a category hidden and then visible again.'.                                                                                                                                        # /Users/stronk7/git_moodle/testing/course/tests/behat/category_change_visibility.feature:11
          Of feature `We can change the visibility of categories in the management interface.'.                                                                                                                         # /Users/stronk7/git_moodle/testing/course/tests/behat/category_change_visibility.feature
       
      08. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test making a subcategory hidden and then visible again.'.                                                                                                                                     # /Users/stronk7/git_moodle/testing/course/tests/behat/category_change_visibility.feature:50
          Of feature `We can change the visibility of categories in the management interface.'.                                                                                                                         # /Users/stronk7/git_moodle/testing/course/tests/behat/category_change_visibility.feature
       
      09. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test relation between category and course when changing visibility.'.                                                                                                                          # /Users/stronk7/git_moodle/testing/course/tests/behat/category_change_visibility.feature:112
          Of feature `We can change the visibility of categories in the management interface.'.                                                                                                                         # /Users/stronk7/git_moodle/testing/course/tests/behat/category_change_visibility.feature
       
      10. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test editing a category through the management interface.'.                                                                                                                                    # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature:14
          Of feature `Test category management actions'.                                                                                                                                                                # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature
       
      11. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test deleting a categories through the management interface.'.                                                                                                                                 # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature:45
          Of feature `Test category management actions'.                                                                                                                                                                # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature
       
      12. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test I can assign roles for a category through the management interface.'.                                                                                                                     # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature:106
          Of feature `Test category management actions'.                                                                                                                                                                # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature
       
      13. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test I can set access permissions for a category through the management interface.'.                                                                                                           # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature:126
          Of feature `Test category management actions'.                                                                                                                                                                # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature
       
      14. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test clicking to manage cohorts for a category through the management interface.'.                                                                                                             # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature:145
          Of feature `Test category management actions'.                                                                                                                                                                # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature
       
      15. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test configuring filters for a category'.                                                                                                                                                      # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature:160
          Of feature `Test category management actions'.                                                                                                                                                                # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature
       
      16. Link matching locator "'Add a category'" not found.
          In step `And I follow "Add a category"'.                                                                                                                                                                      # behat_general::click_link()
          From scenario `Test that is not possible to create a course category with a duplicate idnumber'.                                                                                                              # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature:336
          Of feature `Test category management actions'.                                                                                                                                                                # /Users/stronk7/git_moodle/testing/course/tests/behat/category_management.feature
       
      17. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test bulk sorting all categories.'.                                                                                                                                                            # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature:8
          Of feature `Test we can resort categories in the management interface.'.                                                                                                                                      # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature
       
      18. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test bulk sorting all categories.'.                                                                                                                                                            # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature:8
          Of feature `Test we can resort categories in the management interface.'.                                                                                                                                      # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature
       
      19. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test bulk sorting current category.'.                                                                                                                                                          # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature:31
          Of feature `Test we can resort categories in the management interface.'.                                                                                                                                      # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature
       
      20. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test bulk sorting current category.'.                                                                                                                                                          # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature:31
          Of feature `Test we can resort categories in the management interface.'.                                                                                                                                      # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature
       
      21. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test resorting subcategories.'.                                                                                                                                                                # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature:58
          Of feature `Test we can resort categories in the management interface.'.                                                                                                                                      # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature
       
      22. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test resorting subcategories.'.                                                                                                                                                                # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature:58
          Of feature `Test we can resort categories in the management interface.'.                                                                                                                                      # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature
       
      23. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test moving categories up and down by one.'.                                                                                                                                                   # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature:110
          Of feature `Test we can resort categories in the management interface.'.                                                                                                                                      # /Users/stronk7/git_moodle/testing/course/tests/behat/category_resort.feature
       
      24. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test displaying of sub categories'.                                                                                                                                                            # /Users/stronk7/git_moodle/testing/course/tests/behat/course_category_management_listing.feature:73
          Of feature `Course category management interface performs as expected'.                                                                                                                                       # /Users/stronk7/git_moodle/testing/course/tests/behat/course_category_management_listing.feature
       
      25. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test pagination is only shown when required'.                                                                                                                                                  # /Users/stronk7/git_moodle/testing/course/tests/behat/course_category_management_listing.feature:512
          Of feature `Course category management interface performs as expected'.                                                                                                                                       # /Users/stronk7/git_moodle/testing/course/tests/behat/course_category_management_listing.feature
       
      26. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test clicking to edit a course.'.                                                                                                                                                              # /Users/stronk7/git_moodle/testing/course/tests/behat/course_category_management_listing.feature:674
          Of feature `Course category management interface performs as expected'.                                                                                                                                       # /Users/stronk7/git_moodle/testing/course/tests/behat/course_category_management_listing.feature
       
      27. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test toggling course visibility through the management interfaces.'.                                                                                                                           # /Users/stronk7/git_moodle/testing/course/tests/behat/course_change_visibility.feature:8
          Of feature `We can change the visibility of courses in the management interface.'.                                                                                                                            # /Users/stronk7/git_moodle/testing/course/tests/behat/course_change_visibility.feature
       
      28. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Resort courses.'.                                                                                                                                                                              # /Users/stronk7/git_moodle/testing/course/tests/behat/course_resort.feature:8
          Of feature `Test we can resort course in the management interface.'.                                                                                                                                          # /Users/stronk7/git_moodle/testing/course/tests/behat/course_resort.feature
       
      29. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Resort courses.'.                                                                                                                                                                              # /Users/stronk7/git_moodle/testing/course/tests/behat/course_resort.feature:8
          Of feature `Test we can resort course in the management interface.'.                                                                                                                                          # /Users/stronk7/git_moodle/testing/course/tests/behat/course_resort.feature
       
      30. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Resort courses.'.                                                                                                                                                                              # /Users/stronk7/git_moodle/testing/course/tests/behat/course_resort.feature:8
          Of feature `Test we can resort course in the management interface.'.                                                                                                                                          # /Users/stronk7/git_moodle/testing/course/tests/behat/course_resort.feature
       
      31. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Test moving courses up and down by one.'.                                                                                                                                                      # /Users/stronk7/git_moodle/testing/course/tests/behat/course_resort.feature:77
          Of feature `Test we can resort course in the management interface.'.                                                                                                                                          # /Users/stronk7/git_moodle/testing/course/tests/behat/course_resort.feature
       
      32. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Create a course'.                                                                                                                                                                              # /Users/stronk7/git_moodle/testing/course/tests/behat/create_delete_course.feature:7
          Of feature `Test we can both create and delete a course.'.                                                                                                                                                    # /Users/stronk7/git_moodle/testing/course/tests/behat/create_delete_course.feature
       
      33. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Delete a course via its management listing'.                                                                                                                                                   # /Users/stronk7/git_moodle/testing/course/tests/behat/create_delete_course.feature:36
          Of feature `Test we can both create and delete a course.'.                                                                                                                                                    # /Users/stronk7/git_moodle/testing/course/tests/behat/create_delete_course.feature
       
      34. Link matching locator "'Manage courses and categories'" not found.
          In step `Given I follow "Manage courses and categories"'.                                                                                                                                                     # behat_general::click_link()
          From scenario `Delete a course via its management details page'.                                                                                                                                              # /Users/stronk7/git_moodle/testing/course/tests/behat/create_delete_course.feature:68
          Of feature `Test we can both create and delete a course.'.                                                                                                                                                    # /Users/stronk7/git_moodle/testing/course/tests/behat/create_delete_course.feature
       
      92 escenarios (58 exitosos, 34 fallidos)
      3054 pasos (2373 exitosos, 647 omitidos, 34 fallidos)
      25m11.257s
      

      Attachments:

      • capture.txt: showing the listing of all the failures leading to the same page with the same 4 settings.
      • capture.html: one of the files above (note it may contain references to my local site)
      • capture.png: showing the .html above in my local site.

        Gliffy Diagrams

          Attachments

          1. capture.html
            74 kB
          2. capture.png
            capture.png
            116 kB
          3. capture.txt
            4 kB

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/May/14