Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45292

Bad RTL filepicker styles

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.5
    • Fix Version/s: 2.5.6, 2.6.3
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide

      2.5.x using both Base and Clean:

      • Install Moodle without the patch, and turn developer mode on.
      • Add the Hebrew (he) language pack, but don't activate it yet.
      • Create a new course.
        • In the new course, make a post in the news forum and open the file picker to add an attachment.
          • Observe that under English, the file picker appears largely as you'd expect it to.
        • Switch your language to Hebrew, then re-open the file picker.
          • Observe that interface elements are badly out of position, particularly on the Private files screen.
      • Apply the patch.
        • Observe that the file picker looks better under both LTR (English) and RTL (Hebrew).

      2.6.x using Base only:

      • Install Moodle without the patch, and turn developer mode on.
      • Add the Hebrew (he) language pack, but don't activate it yet.
      • Create a new course.
        • In the new course, make a post in the news forum and open the file picker to add an attachment.
          • Observe that under English, the file picker appears largely as you'd expect it to.
        • Switch your language to Hebrew, then re-open the file picker.
      • Apply the patch.
        • Observe that the file picker looks better under both LTR (English) and RTL (Hebrew).
      Show
      2.5.x using both Base and Clean : Install Moodle without the patch, and turn developer mode on. Add the Hebrew (he) language pack, but don't activate it yet. Create a new course. In the new course, make a post in the news forum and open the file picker to add an attachment. Observe that under English, the file picker appears largely as you'd expect it to. Switch your language to Hebrew, then re-open the file picker. Observe that interface elements are badly out of position, particularly on the Private files screen. Apply the patch. Observe that the file picker looks better under both LTR (English) and RTL (Hebrew). 2.6.x using Base only: Install Moodle without the patch, and turn developer mode on. Add the Hebrew (he) language pack, but don't activate it yet. Create a new course. In the new course, make a post in the news forum and open the file picker to add an attachment. Observe that under English, the file picker appears largely as you'd expect it to. Switch your language to Hebrew, then re-open the file picker. Observe that there are some border issues with the picker ( https://tracker.moodle.org/secure/attachment/37975/26%20Private%20files.png ). Apply the patch. Observe that the file picker looks better under both LTR (English) and RTL (Hebrew).
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45292-master
    • Story Points:
      5

      Description

      A few CSS styles in the filepicker only look good on LTR, or at the very least don't consider RTL circumstances.

      2.5.x:
      theme/base/filemanager.css

      • line 72, .fp-toolbar div padding-right rule
        • applies erroneously under RTL
      • line 72, .dir-rtl .fp-toolbar div width:100px rule
      • line 74, .fp-toolbar img margin-right rule
        • applies erroneously under RTL
      • line 79, .fp-viewbar style definition includes an 8px margin-right under LTR (Recent files LTR.png)
        • not a problem under RTL since in that circumstance the element in question floats left; this rule should be removed
        • need a text-align rule (and an RTL rule to match) because the viewbar is actually narrower than 72px; it takes up 72px, but due to negative margins actually appears smaller.
      • line 81, .dir-rtl .fp-viewbar definition includes an explicit width declaration @ 100px (Private files RTL.png)
        • 72px is enough and we need horizontal space for Alfresco's selectbox (see MDL-36836)

      2.6.x: ( https://tracker.moodle.org/secure/attachment/37975/26%20Private%20files.png )
      theme/base/filemanager.css

      • line 73, .file-picker .fp-toolbar div, .fp-navbar .filemanager-toolbar .fp-toolbar div margin rule
        • no matching RTL definition
      • line 89, .dir-rtl .file-picker .fp-viewbar margin-left:0 rule
        • erroneous - puts the viewbar right up against the border

        Attachments

        1. 26 Private files.png
          26 Private files.png
          17 kB
        2. Private files LTR.png
          Private files LTR.png
          20 kB
        3. Private files RTL.png
          Private files RTL.png
          21 kB
        4. Private files RTL fixed.png
          Private files RTL fixed.png
          21 kB
        5. Recent files LTR.png
          Recent files LTR.png
          18 kB
        6. Server files LTR fixed.png
          Server files LTR fixed.png
          22 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14