Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45298

Keep old user/category/course/site theme settings during 2.7 upgrade to make it easier for admins who want to keep using old themes

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Set up

      1. Checkout and install a new instance as of this commit: 9b8555f
      2. Enable:
        • allowcategorythemes
        • allowcoursethemes
        • allowuserthemes
      3. Create 2 courses in the category Miscellaneous
        • Course A with setting to force the theme to afterburner
        • Course B not forcing the theme
      4. Edit the category Miscellaneous and force the theme to anomaly
      5. Edit your users settings and set the theme to arialist
      6. In the theme selector set:
        • Default to binarius
        • Legacy to boxxie
        • Mobile to brick
        • Tablet to formal_white
      7. Set a customcss in the settings for Afterburner and Anomaly
      8. Checkout the latest integration master
      9. Download theme_brick, and theme_anomaly from Moodle.org and restore them in the theme directory
        • mdk download theme_brick
        • mdk download theme_anomaly

      Upgrade

      1. Proceed with the upgrade process
      2. As a guest, make sure the front page is using Clean
      3. Login as the user used during Set up
      4. Make sure that:
        • Course A is using Clean
        • Course B is using Anomaly
        • The front page is using Clean
      5. Go to the theme selector, make sure that
        • Default, Legacy and Tablet are using Clean
        • Mobile is using brick
      6. Make sure the customcss for Anomaly hasn't changed
      7. Download and restore the themes afterburner, arialist and binarius
      8. Make sure the customcss for Afterburner is as it was before
      9. Make sure:
        • Course A is now displaying Afterburner
        • The front page when logged in is Arialist
        • The front page as guest is still Clean

      Repeat the whole test, but this time checkout the latest 2.6 stable in Set up

      Show
      Set up Checkout and install a new instance as of this commit: 9b8555f Enable: allowcategorythemes allowcoursethemes allowuserthemes Create 2 courses in the category Miscellaneous Course A with setting to force the theme to afterburner Course B not forcing the theme Edit the category Miscellaneous and force the theme to anomaly Edit your users settings and set the theme to arialist In the theme selector set: Default to binarius Legacy to boxxie Mobile to brick Tablet to formal_white Set a customcss in the settings for Afterburner and Anomaly Checkout the latest integration master Download theme_brick, and theme_anomaly from Moodle.org and restore them in the theme directory mdk download theme_brick mdk download theme_anomaly Upgrade Proceed with the upgrade process As a guest, make sure the front page is using Clean Login as the user used during Set up Make sure that: Course A is using Clean Course B is using Anomaly The front page is using Clean Go to the theme selector, make sure that Default, Legacy and Tablet are using Clean Mobile is using brick Make sure the customcss for Anomaly hasn't changed Download and restore the themes afterburner, arialist and binarius Make sure the customcss for Afterburner is as it was before Make sure : Course A is now displaying Afterburner The front page when logged in is Arialist The front page as guest is still Clean Repeat the whole test, but this time checkout the latest 2.6 stable in Set up
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45298-master

      Description

      If a site was using retired themes:

      • As a user setting
      • A category setting
      • A course setting
      • Site setting

      Those settings will be forced to Clean after upgrade, and the retired theme specific settings will be lost, when the retired theme is missing.

      There are a few things we can consider:

      • Warning the admin, before upgrade, about the possible loss of setting if a theme they were using is missing
      • Not purging the theme specific settings
      • Not overwriting the setting for course, category, etc... but setting it back to "default".

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Marina Glancy
              Integrator:
              Dan Poltawski
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14