Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45301

Add font option in EditPDF configuration

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.6, 2.6.2, 3.2
    • Fix Version/s: FRONTEND
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Navigate to Site administration / ► Plugins / ► Activity modules / ► Assignment / ► Feedback plugins / ► Annotate PDF
      2. Choose the proper ("FreeSans") font from the "Font name", that you know supports your local language ( Example: choose "FreeSans" for Hebrew comments). If none of the fonts on the list support your language, Use the internet to find one that does and upload it to the Moodle server under moodle/lib/tcpdf/fonts. And reload the setting page.
      3. On a test course, Create an Assignment activity and select the Submission type "File submission".
      4. Fill all the other settings and save.
      5. Login as a student and upload a PDF file. (Sample file is attached)
      6. Login as Teacher and choose "View/grade all submissions"
      7. Click the Edit > Grade on the student's submission.
      8. Click the "Launch PDF editor"
      9. Add some comments and exit (click the "X" icon on the editor's header)
      10. Now that the editor is closed, click "Save changes" to go back to the "View/grade all submissions" page.
      11. Click the PDF file that was created under the "Annotate PDF", to download it.
      12. Open the downloaded PDF fle and make sure the comments are readable in your local language (i.e Hebrew) as they were when you input them inside the Online editor on section (9)
      Show
      Navigate to Site administration / ► Plugins / ► Activity modules / ► Assignment / ► Feedback plugins / ► Annotate PDF Choose the proper ("FreeSans") font from the "Font name", that you know supports your local language ( Example: choose "FreeSans" for Hebrew comments). If none of the fonts on the list support your language, Use the internet to find one that does and upload it to the Moodle server under moodle/lib/tcpdf/fonts. And reload the setting page. On a test course, Create an Assignment activity and select the Submission type "File submission". Fill all the other settings and save. Login as a student and upload a PDF file. (Sample file is attached) Login as Teacher and choose "View/grade all submissions" Click the Edit > Grade on the student's submission. Click the "Launch PDF editor" Add some comments and exit (click the "X" icon on the editor's header) Now that the editor is closed, click "Save changes" to go back to the "View/grade all submissions" page. Click the PDF file that was created under the "Annotate PDF", to download it. Open the downloaded PDF fle and make sure the comments are readable in your local language (i.e Hebrew) as they were when you input them inside the Online editor on section (9)
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_32_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45301_master

      Description

      Using multi-byte string like Japanese, EditPDF editor page display properly (fig1). But download annotated PDF are not properly (fig2).
      $this->SetFont() method in mod/feedback/editpdf/classes/pdf.php cause this problem. When I change font to 'kozgopromedium', problem is resolved (fig3).

      So please add font option in EditPDF configuration.

        Attachments

        1. Organic Agriculture.pdf
          211 kB
        2. fig3.png
          fig3.png
          12 kB
        3. fig2.png
          fig2.png
          11 kB
        4. fig1.png
          fig1.png
          28 kB

          Issue Links

            Activity

              People

              • Votes:
                8 Vote for this issue
                Watchers:
                16 Start watching this issue

                Dates

                • Created:
                  Updated: