Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45324

Grading notifications are sent before the grades are released to students

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Prerequisite.
      1. A site that is able to send out emails.
      Test 1
      1. Create an assignment with 'Use marking workflow' set to 'Yes'.
      2. As a student with valid email address go and make a submission.
      3. As a teacher click on the assignment and then 'View/grade all submissions'.
      4. Click on the grade icon next to the student.
      5. Check that you can not set 'Notify students' to 'Yes' unless 'Marking workflow state' is set to 'Released'.
      6. Turn off JS and refresh the page.
      7. Change the 'Marking workflow state' to anything but 'Released' and 'Notify students' to 'Yes'.
      8. Submit the form and ensure you get the validation error that makes sense preventing you from submitting to the form.
      9. Re-enable JS and refresh the page.
      10. Change the 'Marking workflow state' to 'Released' and 'Notify students' to 'No'.
      11. Submit the form.
      12. Run the cron and ensure an email is not sent to the student.
      13. Change 'Notify students' to 'Yes'.
      14. Submit the form.
      15. Run the cron and ensure an email is sent to the student.
      Test 2
      1. Create an assignment with 'Use marking workflow' set to 'Yes'.
      2. As two students with valid email addresses go and make a submission.
      3. As a teacher click on the assignment and then 'View/grade all submissions'.
      4. Click on the grade icon next to each student and set the marking workflow state to anything but 'Released'.
      5. Go back to the grading page that lists all the students.
      6. Click on the checkboxes next to both students and then in the select box 'With selected...' select 'Set marking workflow state'.
      7. Check that you can not set 'Notify students' to 'Yes' unless 'Marking workflow state' is set to 'Released'.
      8. Turn off JS and refresh the page.
      9. Set the 'Marking workflow state' to anything but 'Released' and 'Notify students' to 'Yes'.
      10. Submit the form.
      11. Run the cron and make sure no emails were sent.
      12. Re-enable JS and refresh the page.
      13. This time set the 'Marking workflow state' to 'Released' and 'Notify students' to 'No'.
      14. Run the cron and make sure the students were not emailed.
      15. Visit the bulk set marking workflow state page again.
      16. This time set 'Notify students' to 'Yes'.
      17. Run the cron and make sure the students were emailed.
      Test 3
      1. Run all the unit tests in mod/assign/tests/*.
      Show
      Prerequisite. A site that is able to send out emails. Test 1 Create an assignment with 'Use marking workflow' set to 'Yes'. As a student with valid email address go and make a submission. As a teacher click on the assignment and then 'View/grade all submissions'. Click on the grade icon next to the student. Check that you can not set 'Notify students' to 'Yes' unless 'Marking workflow state' is set to 'Released'. Turn off JS and refresh the page. Change the 'Marking workflow state' to anything but 'Released' and 'Notify students' to 'Yes'. Submit the form and ensure you get the validation error that makes sense preventing you from submitting to the form. Re-enable JS and refresh the page. Change the 'Marking workflow state' to 'Released' and 'Notify students' to 'No'. Submit the form. Run the cron and ensure an email is not sent to the student. Change 'Notify students' to 'Yes'. Submit the form. Run the cron and ensure an email is sent to the student. Test 2 Create an assignment with 'Use marking workflow' set to 'Yes'. As two students with valid email addresses go and make a submission. As a teacher click on the assignment and then 'View/grade all submissions'. Click on the grade icon next to each student and set the marking workflow state to anything but 'Released'. Go back to the grading page that lists all the students. Click on the checkboxes next to both students and then in the select box 'With selected...' select 'Set marking workflow state'. Check that you can not set 'Notify students' to 'Yes' unless 'Marking workflow state' is set to 'Released'. Turn off JS and refresh the page. Set the 'Marking workflow state' to anything but 'Released' and 'Notify students' to 'Yes'. Submit the form. Run the cron and make sure no emails were sent. Re-enable JS and refresh the page. This time set the 'Marking workflow state' to 'Released' and 'Notify students' to 'No'. Run the cron and make sure the students were not emailed. Visit the bulk set marking workflow state page again. This time set 'Notify students' to 'Yes'. Run the cron and make sure the students were emailed. Test 3 Run all the unit tests in mod/assign/tests/*.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Using Moodle 2.6.1
      1. Create a standard Moodle assignment
      2. Enable "marking workflow"
      3. As a student with real email address go and make a submission on the link
      4. As a teacher, mark the paper, provide some feedback and provide a grade.
      5. Change the paper status to "In marking, Marking completed, In review, Ready for release"
      6. The student will receive an automatic email from the system to say that "Your tutor has posted some feedback, you can see it here...." but they cannot see it until the workflow is set to "released"

      This creates a lot of confusion...

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jonof Jonathon Fowler
              Reporter:
              aa7670 Marius Jugariu
              Peer reviewer:
              Mark Nelson
              Integrator:
              Dan Poltawski
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              11 Vote for this issue
              Watchers:
              19 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15