[MDL-45338] Atto selectionchanged events not fired for touch events - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

On several devices including both touch-based, and mouse-based:

Standard desktop browsers

iOS browsers

Android browsers

Chrome in touch emulation mode

Within Atto:

Select some text

Toggle bold

Confirm that the button state is updated

Note, that ~~MDL-45253~~ may confuse matters here. I had to stick in a Y.log() during testing to make sure that the event was called even though I wasnt' seeing it properly.
Show
On several devices including both touch-based, and mouse-based: Standard desktop browsers iOS browsers Android browsers Chrome in touch emulation mode Within Atto: Select some text Toggle bold Confirm that the button state is updated Note, that MDL-45253 may confuse matters here. I had to stick in a Y.log() during testing to make sure that the event was called even though I wasnt' seeing it properly.
Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-45338~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/08b9068...MDL-45338-master

The button highlighting does not trigger consistently on iOS.

This is probably because we are listening for "click" and not "touch" events to trigger the selectionchanged event.

Testing discovered

MDL-45239 Atto does not focus on the editor after button pushes in Firefox

Participants:: Andrew Nicols, CiBoT, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Jason Fowler

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze