Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45343

Behaviour of date filter is changed in 2.7 for log reports

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: Reports
    • Testing Instructions:
      Hide
      1. Login in to a site that has lots of activity in the past month, so you have fair amount of logs.
      2. Go to My home ► Site administration ► Reports ► Logs and select a date filter and click on get logs
      3. Make sure you see only logs for the selected date.
      4. Repeat the test for a different log store and make sure still works.
      5. Repeat the test for Course reports (My home ► Some Course ► Reports ► Logs)
      Show
      Login in to a site that has lots of activity in the past month, so you have fair amount of logs. Go to My home ► Site administration ► Reports ► Logs and select a date filter and click on get logs Make sure you see only logs for the selected date. Repeat the test for a different log store and make sure still works. Repeat the test for Course reports (My home ► Some Course ► Reports ► Logs)
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-45343-master

      Description

      As reported by Mary in dev chat:-

      In Moodle 2.6, When you select a date, you can see logs only for that date only.
      However in Moodle 2.7, it shows you logs since that date.

      2.6 sql filter

      $enddate = $date + 86400;
      $joins[] = "l.time > :date AND l.time < :enddate";
      

      2.7 sql filter

      $filter->date = $this->date;
      $joins[] = "timecreated > :date";
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              ankit_frenz Ankit Agarwal
              Peer reviewer:
              Petr Skoda
              Integrator:
              Marina Glancy
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14