Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45359

Non-modal dialogue in a modal dialogue has mask issues

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.2
    • Fix Version/s: 2.6.3, 2.7
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Mask == lightbox == that grey thing in the background you sometimes get (for modal dialogues only)

      1. Check various Moodle dialogues to make sure that they do not appear behind their masks:
        • activity chooser
        • qbank chooser (2.7 only)
        • editpdf
        • block mover (the popup version)
      2. Check there are no errors when opening various non-modal dialogues:
        • help popups
      3. Un-tgz the attached file (45359.tgz) into your root directory
      4. Point your browser at http://path/to/moodle/45359
      5. Click on the
        • Confirm that the help dialogue is shown correctly without a mask
      6. Close it, re-open, and confirm again
      7. Close it
      8. Click on the 'Click me' text
        • Confirm that the dialogue is shown correctly in front of it's mask
      9. Click on the icon in it
        • Confirm that the mask is still shown behind both dialogues
        • Confirm that the help dialogue is in front
      10. Close it with it's [X]
      11. Re-open, and re-confirm
      12. Close both dialogues
      13. Re-open the dialogue
        • Reconfirm
      14. Refresh the page
      15. Open the popup (not the help) immediately this time
      16. Repeat previous set of tests on this dialogue again
      17. Close and check the help button on the page itself again
      Show
      Mask == lightbox == that grey thing in the background you sometimes get (for modal dialogues only) Check various Moodle dialogues to make sure that they do not appear behind their masks: activity chooser qbank chooser (2.7 only) editpdf block mover (the popup version) Check there are no errors when opening various non-modal dialogues: help popups Un-tgz the attached file (45359.tgz) into your root directory Point your browser at http://path/to/moodle/45359 Click on the Confirm that the help dialogue is shown correctly without a mask Close it, re-open, and confirm again Close it Click on the 'Click me' text Confirm that the dialogue is shown correctly in front of it's mask Click on the icon in it Confirm that the mask is still shown behind both dialogues Confirm that the help dialogue is in front Close it with it's [X] Re-open, and re-confirm Close both dialogues Re-open the dialogue Reconfirm Refresh the page Open the popup (not the help) immediately this time Repeat previous set of tests on this dialogue again Close and check the help button on the page itself again
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-45359-master

      Description

      If you have a help button within a YUI modal window and click it, it doesn't show and removes the overlay (but keeps the existing dialogue open). This allows the pages functionality to be interacted with.

        Attachments

        1. helptest.tgz
          31 kB
        2. 45359.tgz
          30 kB

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              brianb Brian Barnes
              Peer reviewer:
              Petr Skoda
              Integrator:
              Damyon Wiese
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14