Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45364

Various lint errors reported by shifter

    Details

    • Testing Instructions:
      Hide

      On all branches:

      A) Run grunt shifter and ensure no shifter errors are experenienced

      B) RTL Plugin (on all branches)
      Repeat testing instructions from MDL-46497 copied below. Note, we are not changing any functionality here, so please only report a regression relating to this patch.

      1. Make sure you are using Atto editor (User's preferences) and that you are using the English UI language.
      2. Navigate to: Site administration ► Plugins ► Text editors ► Atto HTML editor ► Atto toolbar settings
      3. Inside "Toolbar config", add ",rtl" to "align = align" (so it looks like "align = align,rtl"). And save settings. (So now you have two new buttons on the Atto's second/hidden toolbar - RTL/LTR)
      4. Navigate into a page where you can use the HTML editor (You can start a Discussion on a Forum or Edit your own user's description on your profile page)
      5. Type into the Atto editor a few words (You can paste: "אני כותב בעברית And also in English וחוזר לכתוב בעברית")
      6. Now, click the "" Atto toolbar button and then click the "" button. And repeat it 2-3 times.
      7. Switch to HTML mode (use the "<>" icon on the Atto's second/hidden toolbar)
      8. Make sure there are no redundant HTML P elements surrounding your text. (As seen on the attached screen capture)

      On master/30 only:

      A) Test for item_is_allocated_to_dropzone change:

      1. Add a new 'drag and drop onto image' question, your going to be testing the this form page only.
      2. Add a Question name/text and upload a background image.
      3. Add three draggable text items 'item one', 'item two' and 'item three'
      4. Tick the unlimited option for item three
      5. In 'drop zones' choose the draggable item 'item one' for Drop zone 1
      6. VERIFY: In Drop zone 2 (and all other drop zones) that the select item for 'item one' is disabled and 'item two' is enabled
      7. In drop zone 2 select 'item two'
      8. VERIFY: In drop zone 3 (and following drop zones), only item 3 is able to be selected
      9. In drop zone 3 select 'item three'
      10. VERIFY: In drop zone 4 (and following drop zones), only item 3 is still able to be selected
      11. Unselect some optins and VERIFY they are then able to be selected in other drop zones

      B) Test for redraw_dd_area change:

      1. Add a new 'drag and drop onto image' question, your going to be testing the this form page only.
      2. Add a Question name/text and upload a background image.
      3. Add two draggable items
        1. First an image with a title 'item one'
        2. Second a text item 'item two'
      4. Allocate the two items to drop zones
      5. They should display on the preview image above
      6. Change item one from an image to a text item
      7. VERIFY: the 'item one' preview changes from an image to a text item
      8. Now change the group of 'item two' and watch the preview
      9. VERIFY: 'item two' preview changes colour to reflect the different group
      1. Tick the unlimited option for item three
      2. In 'drop zones' choose the draggable item 'item one' for Drop zone 1
      3. VERIFY: In Drop zone 2 (and all other drop zones) that the select item for 'item one' is disabled and 'item two' is enabled
      4. In drop zone 2 select 'item two'
      5. VERIFY: In drop zone 3 (and following drop zones), only item 3 is able to be selected
      6. In drop zone 3 select 'item three'
      7. VERIFY: In drop zone 4 (and following drop zones), only item 3 is still able to be selected
      8. Unselect some optins and VERIFY they are then able to be selected in other drop zones

      c) Run behat --tags @qtype_ddimageortext

      Show
      On all branches: A) Run grunt shifter and ensure no shifter errors are experenienced B) RTL Plugin (on all branches) Repeat testing instructions from MDL-46497 copied below. Note, we are not changing any functionality here, so please only report a regression relating to this patch. Make sure you are using Atto editor (User's preferences) and that you are using the English UI language. Navigate to: Site administration ► Plugins ► Text editors ► Atto HTML editor ► Atto toolbar settings Inside "Toolbar config", add ",rtl" to "align = align" (so it looks like "align = align,rtl"). And save settings. (So now you have two new buttons on the Atto's second/hidden toolbar - RTL/LTR) Navigate into a page where you can use the HTML editor (You can start a Discussion on a Forum or Edit your own user's description on your profile page) Type into the Atto editor a few words (You can paste: "אני כותב בעברית And also in English וחוזר לכתוב בעברית") Now, click the "" Atto toolbar button and then click the "" button. And repeat it 2-3 times. Switch to HTML mode (use the "<>" icon on the Atto's second/hidden toolbar) Make sure there are no redundant HTML P elements surrounding your text. (As seen on the attached screen capture) On master/30 only: A) Test for item_is_allocated_to_dropzone change: Add a new 'drag and drop onto image' question, your going to be testing the this form page only. Add a Question name/text and upload a background image. Add three draggable text items 'item one', 'item two' and 'item three' Tick the unlimited option for item three In 'drop zones' choose the draggable item 'item one' for Drop zone 1 VERIFY: In Drop zone 2 (and all other drop zones) that the select item for 'item one' is disabled and 'item two' is enabled In drop zone 2 select 'item two' VERIFY: In drop zone 3 (and following drop zones), only item 3 is able to be selected In drop zone 3 select 'item three' VERIFY: In drop zone 4 (and following drop zones), only item 3 is still able to be selected Unselect some optins and VERIFY they are then able to be selected in other drop zones B) Test for redraw_dd_area change: Add a new 'drag and drop onto image' question, your going to be testing the this form page only. Add a Question name/text and upload a background image. Add two draggable items First an image with a title 'item one' Second a text item 'item two' Allocate the two items to drop zones They should display on the preview image above Change item one from an image to a text item VERIFY: the 'item one' preview changes from an image to a text item Now change the group of 'item two' and watch the preview VERIFY: 'item two' preview changes colour to reflect the different group Tick the unlimited option for item three In 'drop zones' choose the draggable item 'item one' for Drop zone 1 VERIFY: In Drop zone 2 (and all other drop zones) that the select item for 'item one' is disabled and 'item two' is enabled In drop zone 2 select 'item two' VERIFY: In drop zone 3 (and following drop zones), only item 3 is able to be selected In drop zone 3 select 'item three' VERIFY: In drop zone 4 (and following drop zones), only item 3 is still able to be selected Unselect some optins and VERIFY they are then able to be selected in other drop zones c) Run behat --tags @qtype_ddimageortext
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-45364-master

      Description

      shifter is reporting lint, ideally we wouldn't have that because it gives the impression we accept lint errors.

      Previously this was caused by a shifter bug, but for a while now its just been actual errors.

      We want to prevent more landing in MDLSITE-4329

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    21/Dec/15