Moodle
  1. Moodle
  2. MDL-45376

Completion: Form locking is still not working right

    Details

      Description

      This sequence demonstrates the problem:

      0. Enable completion at system and course level.
      1. Create a new Forum. Set it to be automatically completed when user makes 1 post/discussion.
      2. Save and display. In the forum, make a discussion.
      3. Edit settings again. Observe that completion settings are now locked because one user (you) has completed it.
      4. Click the unlock button.
      5. Observe that on the reloaded form, completion settings are now enabled and appear correctly (with the 'require 1 post/discussion' ticked).
      6. Save and display.

      EXPECTED: It should save the changes (clearing completion status, but basically no change).
      ACTUAL: 'When you select automatic completion, you must also enable at least one requirement (below)' error.

      7. Edit settings again.

      EXPECTED: The settings should be as before (require 1 post/discussion). They'll be locked again.

      Seen in 2.6.2 and in current master. (Might also affect 2.5, unknown.)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Sam Marshall added a comment -

            Tim reviewed this, so submitting for integration - think it's good.

            Note: The whole 'unlock' thing is a bit sketchy - it should be revamped completely at some point, along with other aspects of the completion system as mentioned in MDL-39624 etc.

            Show
            Sam Marshall added a comment - Tim reviewed this, so submitting for integration - think it's good. Note: The whole 'unlock' thing is a bit sketchy - it should be revamped completely at some point, along with other aspects of the completion system as mentioned in MDL-39624 etc.
            Hide
            Dan Poltawski added a comment -

            Integrated to master, 25 and 26 - thanks Sam

            Show
            Dan Poltawski added a comment - Integrated to master, 25 and 26 - thanks Sam
            Hide
            Simey Lameze added a comment -

            Thanks for working on this Sam, test passed!

            Show
            Simey Lameze added a comment - Thanks for working on this Sam, test passed!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            M A N Y T H A N K S ! !

            This is now part of Moodle, the LMS beast eating developers for breakfast.

            Closing as fixed, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - M A N Y T H A N K S ! ! This is now part of Moodle, the LMS beast eating developers for breakfast. Closing as fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: