Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45388

Add some info to the performance footer when theme designer mode is on

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 3.2
    • 2.7, 3.2
    • Performance, Themes
    • MOODLE_27_STABLE, MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-45388-master
    • Hide
      1. Enable perfdebug and verify you can see the performance footer on all pages
      2. Enable theme designer mode
      3. VERIFY: a warning is displayed about it in the admin index page
      4. Browse to course page
      5. VERIFY: a warning about theme designer mode is displayed in the performance footer
      6. Disable theme designer mode
      7. VERIFY: the warnings about theme designer mode are no longer displayed
      Show
      Enable perfdebug and verify you can see the performance footer on all pages Enable theme designer mode VERIFY: a warning is displayed about it in the admin index page Browse to course page VERIFY: a warning about theme designer mode is displayed in the performance footer Disable theme designer mode VERIFY: the warnings about theme designer mode are no longer displayed

    Description

      I've almost started investigating performance issues a few times because i've been tripped up by being in theme designer mode and using the more theme and wondered why things are going so slow. (The reason which I am well aware of is because of the slow dynamic compiling of less).

      It would be good to add something obvious to the performance info footer to make it obvious that this is impacting the responsiveness of the page. Today when I experienced it I only twigged why it was happening because I saw the themedesignermode adhoc cache (and i'm really familiar this problem).

      To someone who doesn't know about this gotcha it would be less obvious.

      I am not sure if its possible to work out from the php page that less is being compiled on the fly, so perhaps theme designer mode is the best we can do (I still think thats useful because it'll warn you that normal caching isn't taking place). But it'd be great if we could indicate that a less compilation is happening too (it helps explain when slower than normal after a theme setting change)

      Attachments

        Activity

          People

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Andrew Lyons Andrew Lyons
            David Monllaó David Monllaó
            Rajesh Taneja Rajesh Taneja
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.