Loading...

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
git://github.com/abgreeve/moodle.git
Pull Main Branch:
wip-~~MDL-45395~~-master
Pull Main Diff URL:
https://github.com/abgreeve/moodle/compare/e7ea6b9...wip-MDL-45395-master
Testing Instructions:
Hide

1) Check the excel files in the following areas and make sure that they download properly.

Bulk user download.

Gradebook.

Choice responses (report).

Feedback module (Analysis tab).

Scorm reports.

Survey.

2) Also do a grep for files with OLE. Make sure that there are none. (git grep -i OLE_ |grep -iv role|grep -iv console|grep -iv whole|grep -v creole)
Show
1) Check the excel files in the following areas and make sure that they download properly. Bulk user download. Gradebook. Choice responses (report). Feedback module (Analysis tab). Scorm reports. Survey. 2) Also do a grep for files with OLE. Make sure that there are none. (git grep -i OLE_ |grep -iv role|grep -iv console|grep -iv whole|grep -v creole)

We removed it in ~~MDL-42381~~..

But as reported by Debian, we have another instance in lib/phpexcel/PHPExcel/Shared/OLE*

It's specified that an 'exception' was made for Moodle. That implies relicensing and is all bit hazy. If we don't need it we should get rid of it..

Discovered while testing

MDL-46035 Survey activity shows wrong error message to admins

MDL-46036 Exception is thrown if you try to download responses from a survey activity with no responses

will be (partly) resolved by

MDL-42381 remove unused OLE lib and pear excel leftovers

links to

Debian Bug #746594

Participants:: Adrian Greeve, Andrew Davis, CiBoT, Damyon Wiese, Dan Poltawski, Martin Dougiamas, Petr Skoda