Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45403

Atto default button highlighting logic is wrong

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enter A LOT of text in Atto, and add many styles, lists, images, links, etc...
      2. CTRL + A to select the whole content
      3. Make sure the browser does not freeze, and the buttons are highlighted as you'd expect
      4. Change your selection, and make sure the browser does not freeze
      5. Move your cursor in various places and make sure the buttons are highlighted as you'd expect
      Show
      Enter A LOT of text in Atto, and add many styles, lists, images, links, etc... CTRL + A to select the whole content Make sure the browser does not freeze, and the buttons are highlighted as you'd expect Change your selection, and make sure the browser does not freeze Move your cursor in various places and make sure the buttons are highlighted as you'd expect
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45403-master

      Description

      Some buttons should highlight only when the entire selection matches the button function (bold, underline, strikethrough, italic)

      Other buttons should highlight when any part of the selection matches the button function (link, image).

      The default for tagMatchRequiresAll should be true (it's the fastest, most common option)
      and image and link should override it to be false.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Dan Poltawski
              Tester:
              Andrew Nicols
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14