Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45517

legacy_add_to_log and add_to_log doesn't check the action field lenght

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 2.6.3, 2.7
    • Fix Version/s: None
    • Component/s: Logging
    • Labels:
      None
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE

      Description

      I've detected this issue calling a WebService function that has a name length about 60 chars

      You can see here how the function name is stored in the action field
      https://github.com/moodle/moodle/blob/master/webservice/lib.php#L1639

      The current action field in the log table is limited to 40 chars so an error is returned (send by email) to the administrator when a client/consumer calls the WebService function.

      After talking with Eloy, it's clear that we should control the size of the action parameter in the add_to_log (2.6) and legacy_add_to_log function (2.7) function

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jleyva Juan Leyva
                Reporter:
                jleyva Juan Leyva
                Participants:
                Component watchers:
                Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: