Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45525

last post column alignment in forums on bootstrapbase RTL

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.5.6, 2.6.3, 2.7
    • Fix Version/s: 2.5.7, 2.6.4, 2.7.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      On Clean or More:

      1. Go to a forum.
        • Observe that the "Replies" header is centered in line with the cells in its column.
      2. Install the Hebrew language pack, and enable it.
      3. Go back to the forum.
        • Observe that the replies header is still centered.
        • Observe that the last post column is now aligned left.
      Show
      On Clean or More: Go to a forum. Observe that the "Replies" header is centered in line with the cells in its column. Install the Hebrew language pack, and enable it. Go back to the forum. Observe that the replies header is still centered. Observe that the last post column is now aligned left.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:

      Description

      Noticed that there was a style rule in bootstrapbase that wasn't being applied to RTL forums; the intent was to align .lastpost text left under RTL, but it never kicked in due to incorrect nesting (.dir-rtl and .path-mod-forum are classes applied to the same element), see https://github.com/moodle/moodle/blame/master/theme/bootstrapbase/less/moodle/modules.less#L260.

      Some minor improvements as well:

      • added minor padding on table cells
      • lined up Replies header with Replies table cells (header was aligned left, cells were aligned center)
      • reduced text size of non-topic cells to make things read a little better

        Gliffy Diagrams

          Attachments

          1. ltr_after.png
            ltr_after.png
            40 kB
          2. ltr_before.png
            ltr_before.png
            42 kB
          3. rtl_after.png
            rtl_after.png
            29 kB
          4. rtl_before.png
            rtl_before.png
            28 kB

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jul/14