Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45535

CSS chunking breaks media rules if CSS invalid (IE)

    XMLWordPrintable

Details

    • MOODLE_26_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • MDL-45535-master
    • Hide

      1. Run unit tests: vendor/bin/phpunit lib/tests/csslib_test.php
      2. Purge caches for your test server.
      3. Look at pages using IE 9 or below and verify styles are working (as well as they did before this change).

      Show
      1. Run unit tests: vendor/bin/phpunit lib/tests/csslib_test.php 2. Purge caches for your test server. 3. Look at pages using IE 9 or below and verify styles are working (as well as they did before this change).

    Description

      After the upgrade to 2.6.3, some of our test servers that were previously working started displaying badly broken CSS in IE8. This appears to be because of MDL-44936 - the CSS is now being chunked in the middle of a media rule.

      I am investigating and will provide a unit test & fix once I figure out what on earth it is. Unfortunately the problem does not happen on my personal dev server which is a bit annoying (presumably different modules on/off)...

      Attachments

        1. ie8sucks.png
          ie8sucks.png
          89 kB
        2. Untitled.png
          Untitled.png
          107 kB

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45545 CSS chunker does not handle commas in media queries

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-44936 CSS chunking is not reliable and can break styles on IE

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              quen Sam Marshall
              quen Sam Marshall
              Frédéric Massart Frédéric Massart
              Sam Hemelryk Sam Hemelryk
              Jason Fowler Jason Fowler
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Jul/14