Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45535

CSS chunking breaks media rules if CSS invalid (IE)

XMLWordPrintable

    • MOODLE_26_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • MDL-45535-master
    • Hide

      1. Run unit tests: vendor/bin/phpunit lib/tests/csslib_test.php
      2. Purge caches for your test server.
      3. Look at pages using IE 9 or below and verify styles are working (as well as they did before this change).

      Show
      1. Run unit tests: vendor/bin/phpunit lib/tests/csslib_test.php 2. Purge caches for your test server. 3. Look at pages using IE 9 or below and verify styles are working (as well as they did before this change).

      After the upgrade to 2.6.3, some of our test servers that were previously working started displaying badly broken CSS in IE8. This appears to be because of MDL-44936 - the CSS is now being chunked in the middle of a media rule.

      I am investigating and will provide a unit test & fix once I figure out what on earth it is. Unfortunately the problem does not happen on my personal dev server which is a bit annoying (presumably different modules on/off)...

        1. Untitled.png
          Untitled.png
          107 kB
        2. ie8sucks.png
          ie8sucks.png
          89 kB

            quen Sam Marshall
            quen Sam Marshall
            Frédéric Massart Frédéric Massart
            Sam Hemelryk Sam Hemelryk
            Jason Fowler Jason Fowler
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.