Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45536

Clean theme overriding text input field sizes

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Open a range of forms and look at the text input fields
      2. Find a field without a size specified (most in Moodle outside of the quiz)
        • *Confirm that it uses the standard input width from bootstrap (look at the inspector)
      3. Find a few with widths. The quiz has several:
        • the question name has a size of 50
        • the marks have a size of 7
      4. Confirm that the sizes look appropriate for the content of the fields
      5. Look at some others (e.g. admin pages) and confirm the sizes are respected there too:

        git grep "'size'.*=>.*[0-9]"
        

      6. Repeat for some textareas specifying column counts:

        git grep "'cols'.*=>.*[0-9]"
        

      7. Open your web inpsector and select a text input
      8. Change the value of size
        • Confirm it's respected and the width changes
      9. Remove the size
        • Confirm that it defaults to the bootstrap default width
      10. Repeat with a textarea and it's "cols" attribute
      Show
      Open a range of forms and look at the text input fields Find a field without a size specified (most in Moodle outside of the quiz) *Confirm that it uses the standard input width from bootstrap (look at the inspector) Find a few with widths. The quiz has several: the question name has a size of 50 the marks have a size of 7 Confirm that the sizes look appropriate for the content of the fields Look at some others (e.g. admin pages) and confirm the sizes are respected there too: git grep "'size'.*=>.*[0-9]" Repeat for some textareas specifying column counts: git grep "'cols'.*=>.*[0-9]" Open your web inpsector and select a text input Change the value of size Confirm it's respected and the width changes Remove the size Confirm that it defaults to the bootstrap default width Repeat with a textarea and it's "cols" attribute
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-45536-master

      Description

      Using Moodle 2.7 with the "default" Clean theme. When editing a short-answer question, I notice that the theme seems to over-ride the "size" (i.e. width) settings of the text input fields. The result is that e.g. the Default mark field and the Answer fields are the same length, with the Default mark field un-necessary wide and the Answer field ridiculously not wide enough.

      Compare with the 2.6 default theme view, where those 2 fields have different (and more sensible) widths (see attached screenshots).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              rezeau Joseph Rézeau
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Marina Glancy
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jul/14